Re: [Builder] builtin plugin development with flatpak-installed builder

[Henry Finucane <h finucane+gb gmail com>]

On Tue, May 8, 2018 at 1:10 AM Christian Hergert <christian hergert me>
wrote:

> On 05/05/2018 08:59 AM, Henry Finucane wrote:
> > I've been trying to test changes to a builtin plugin with a copy of
Builder
> > installed from flatpak, and my current strategy has been to disable the
> > original, copy it to ~/.local/share/gnome-builder/plugins/, change the
name
> > of the python module, and change the name of the plugin. This works, but
> > it's also sort of a pain, and I wonder if I'm missing something? Can I
> > sideload things into the flatpak? Should I just buckle down and get full
> > flatpak builds of Builder working?

> The .local/share/gnome-builder/plugins/ directory should be higher
> priority than anything bundled/installed. Have you found renaming the
> plugin to be necessary?

I have. I ran around a bit because I had been running on master, and I
think something else broke, but I did a full walkthrough on 3.28.1 again,
and I can reproduce. This is my basic test-

     ~/.local/share/gnome-builder/plugins/go-langserv$ git diff
     diff --git a/src/plugins/go-langserv/go_langserver_plugin.py
b/src/plugins/go-langserv/go_langserver_plugin.py
     index d24575f..7acb6f3 100644
     --- a/src/plugins/go-langserv/go_langserver_plugin.py
     +++ b/src/plugins/go-langserv/go_langserver_plugin.py
     @@ -12,6 +12,7 @@ from gi.repository import Ide

      DEV_MODE = os.getenv('DEV_MODE') and True or False

     +print("XXX local plugin loaded")

      class GoService(Ide.Object, Ide.Service):
          _client = None


and I don't see anything after `flatpak run` and loading a Go project.
Adding

     diff --git a/src/plugins/go-langserv/go-langserv.plugin
b/src/plugins/go-langserv/go-langserv.plugin
     index be8454d..b51018d 100644
     --- a/src/plugins/go-langserv/go-langserv.plugin
     +++ b/src/plugins/go-langserv/go-langserv.plugin
     @@ -4,7 +4,7 @@ Loader=python3
      Name=Go Langserver Plugin
      Description=Provides LSP integration for Go
      Copyright=Copyright © 2018
     -Builtin=true
     +Builtin=false

      X-Symbol-Resolver-Languages=go

doesn't help either. This will get it going-

     ~/.local/share/gnome-builder/plugins/go-langserv$ git status
     On branch go-langserver
     Your branch is up-to-date with 'origin/go-langserver'.
     Changes to be committed:
       (use "git reset HEAD <file>..." to unstage)

         modified:   go-langserv.plugin
         renamed:    go_langserver_plugin.py -> go_langserver_plugin2.py

     ~/.local/share/gnome-builder/plugins/go-langserv$ git diff HEAD
go-langserv.plugin
     diff --git a/src/plugins/go-langserv/go-langserv.plugin
b/src/plugins/go-langserv/go-langserv.plugin
     index be8454d..a011b5b 100644
     --- a/src/plugins/go-langserv/go-langserv.plugin
     +++ b/src/plugins/go-langserv/go-langserv.plugin
     @@ -1,7 +1,7 @@
      [Plugin]
     -Module=go_langserver_plugin
     +Module=go_langserver_plugin2
      Loader=python3
     -Name=Go Langserver Plugin
     +Name=Go Langserver Plugin2
      Description=Provides LSP integration for Go
      Copyright=Copyright © 2018
      Builtin=true
     ~/.local/share/gnome-builder/plugins/go-langserv$ flatpak run
org.gnome.Builder/x86_64/stable
     XXX HELLO WORLD