Re: [BuildStream] Invalid characters for element names

[Sander Striker <s striker striker nl>]

Looking at Bazel which is in a similar space, it seems to allow:

Target names allow all 7-bit ASCII characters except

  0-31 (control characters)

  58 ':' (colon)

  92 '\' (backslash) - directory separator (on Windows); may be allowed in the future

  127 (delete)

On Fri, Dec 7, 2018 at 4:57 PM Chandan Singh <chandan chandansingh net> wrote:

Hi all,

As we already use colon (`:`) as a separator for specifying cross-junction
elements, I was wondering if it would make sense to disallow elements to have
it in their names. This was bought up in comments on #809 [1] and !998 [2].

As we discussed on GitLab, this is already an issue for the CLI as it will not
work correctly if a project has a junction element with `:` in its name. So, I
think we should maintain a list of invalid characters and disallow elements
that violate this policy. I imagine this check to work in the same the recent
change for mandating `.bst` extension works.

While we are doing this change, are there any characters that we would like to
disallow from element names, and reserve them for internal use?

If I don't hear back on this, I will assume that there are no objections and
will proceed to submitting a merge request for the change.

[1]: https://gitlab.com/BuildStream/buildstream/issues/809#note_123194269
[2]: https://gitlab.com/BuildStream/buildstream/merge_requests/998#note_123204414

Thanks,
Chandan
_______________________________________________
BuildStream-list mailing list
BuildStream-list gnome org
https://mail.gnome.org/mailman/listinfo/buildstream-list