Re: [BuildStream] Guidance on unit tests

[Angelos Evripiotis <angelos evripiotis gmail com>]

Hiya Tristan,

On Tue, Nov 27, 2018 at 9:45 AM Tristan Van Berkom
<tristan vanberkom codethink co uk> wrote:
> Hi Angelos,
>
> On Mon, 2018-11-26 at 22:53 +0400, Angelos Evripiotis wrote:
> > On Thu, Nov 22, 2018 at 1:50 PM Angelos Evripiotis
> > <angelos evripiotis gmail com> wrote:
> > > [...]
> > > On Tue, 20 Nov 2018 at 10:33, Tristan Van Berkom via BuildStream-
> > > list
> > > <buildstream-list gnome org> wrote:
> > > > [...]
>
> I'll re-add a relevant part that you snipped here:
>
>     "Do you agree with Jim and myself on the above conversation ?"
>
> > > > As you wrote this last patch to the guide, I do hope that you will
> > > > offer up an alternative.
> > >
> > > Of course! I think there's enough said for me to start another MR,
> > > I'll post a link back here when it's ready.
> >
> > Here we go:
> > https://gitlab.com/BuildStream/buildstream/merge_requests/973
>
> After adding many comments to !973 above, I would assert that no, you
> probably do not agree, so maybe this is worth discussing further
> first ?

I'm a bit confused by this repeated question, I think perhaps you
missed my previous reply in the GitLab message deluge :)

Here's that bit:

> > Do you agree with Jim and myself on the above conversation ?
>
> I happily agree with the pro-testing-in-general bits, I'm glad to work
> on such a project that is clearly shaped from experience.
>
> Not the anti-function-testing bit, I can't propose something that
> rules them out. I'll avoid that for now and see if we can still move
> forward.

It seems like we did perhaps move forward somewhat, but we are now
stuck on the definition of 'unit', 'component', or 'rivet' when it
comes to testing.

Here I'm first going to aim to just not cross any of my own red lines,
rather than try to convince you of my point of view.

I'm grealy encouraged that it looks like we agree about some of the
things that do deserve testing independently of the cli.

Next I'll reply again wtiha a copy of the relevant MR discussion.

> Cheers,
>     -Tristan

Cheers!
Angelos