Re: [BuildStream] Proposal: Allowing download-only sources to work on local files

[Tom Mewett <tom mewett codethink co uk>]

On Thu, 05 Dec 2019 14:10:34 +0100
Jürg Billeter <j bitron ch> wrote:

> Have you thought about how exactly to deal with (local) directories?
> They probably only make sense for the local source and not any of the
> other potential FileBasedSource plugins.

Yes, this is a special case; I imagined FileBasedSource having some
instance variable which is set on initialisation according to whether
the path is a file or directory (throwing an error if it doesn't
exist). Subclasses would have to throw an error (via some
assert_is_file method?) if they can't handle directories.


On Fri, 06 Dec 2019 11:18:26 +0000
tristan maat codethink co uk (Tristan Daniël Maat) wrote:

> My main problem with this is that it will cause a fair bit of churn on
> the project end [...]
>
> My second point is that this is a non-standard extension of URI. I
> wanted to deliberately avoid that, because it's not a particularly nice
> thing to do; especially because URIs are by definition expected to point
> to an absolute location.

For all my reading of information on URIs I can't find anything that
confirms this - but I do agree that it would be unnecessary breakage
when there is a backwards-compatible option available. So 'url' and
'path' keys seem the sensible solution.


Thank you all for your feedback. Taking it all into account, if no one
has any further issues I'll begin putting together a branch to
implement this.

-- 
Tom Mewett <tom mewett codethink co uk>