Re: [BuildStream] Proposal: Consider adding type hints
- From: Tristan Van Berkom <tristan vanberkom codethink co uk>
- To: James Ennis <james ennis codethink co uk>, Chandan Singh <chandan chandansingh net>
- Cc: buildstream-list gnome org
- Subject: Re: [BuildStream] Proposal: Consider adding type hints
- Date: Wed, 26 Jun 2019 19:49:08 +0900
On Wed, 2019-06-26 at 11:17 +0100, James Ennis via buildstream-list wrote:
Hi Chandan,
[...]
Another +1 from me, I think it's a great idea.
The tutorial includes a "Pros and Cons" section [7] which I thinkĀ
strengthens
your proposal. There are no "Cons" listed here which I think provide
a good enough reason to reject this proposal.
Just bear in mind that we support >= python3.5, it seems that variable
annotations [8] e.g. `pi: float = 3.14159` were not introduced until
Python 3.6.
Just chiming in here on that limitation... given that BuildStream 2 is
not going to be released for quite some time, it may be fair to drop
python 3.5 support if it becomes unwieldy, at least something that we
can consider.
Cheers,
-Tristan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]