Re: [BuildStream] [Development topic] Use black to format code



On 05/11/2019 13:53, Tom Pollard via buildstream-list wrote:
Hi Chandan

I for one am definitely in favour of introducing Black to the
Buildstream source, and can live with an initial 'cleanup' commit.
However, how do you propose the use of Black going forward? Do you
expect it to become a manual part of the contributors workflow, or part
of some pre-commit/merge automation? I've also seen projects using Black
for scheduled blanket format commits, I can't say I'm too keen on that
though.

Cheers,

Tom


I'm opposed to blanket format commits: I don't know anyone who reads
them and we're entirely relying on a tool for that. I suggest if it's
going to replace pycodestyle then it should be part of the pipeline
for MRs and it could also be a pre-commit hook.

-- 
Best Regards,
Darius


For Codethink's privacy-policy please see
https://www.codethink.co.uk/privacy.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]