Re: [BuildStream] Formalizing committers

[Jürg Billeter <j bitron ch>]

Hi Tristan,

On Fri, 2020-05-29 at 15:49 +0900, Tristan Van Berkom wrote:
> [...]
>
> The first step here is to change our policy around technical
> governance[1] and define our initial committers, and I think the
> easiest way forward is to adopt the subversion project's guidelines[2]
> to a minimal degree - causing minimal friction/change at this time, and
> allowing us to more formally adopt further policy after a migration to
> ASF.

This sounds good to me. Thanks for writing this up.

> Actions
> ~~~~~~~
> Unless there are changes introduced by this discussion, the following
> actions will take effect after a short grace period:
>
> * A new COMMITTERS file will be added as a simple text file with a list
>   of the project's committers.
>
> * The gitlab membership statuses and ability to merge will be adjusted
>   so that only committers can merge to protected branches.

How do we handle this with the Marge bot? Right now anyone who can
assign an MR to Marge can effectively merge to master.

Would it make sense to enable merge request approvals, requiring at
least 1 approval from a committer but allowing an MR author to approve
their own MR as well (if they are a committer)? I think this would
match the commit policy and also work with Marge.

I.e., uncheck 'Prevent approval of merge requests by merge request
author' and maybe also uncheck 'Can override approvers and approvals
required per merge request' in the GitLab project settings.

Cheers,
Jürg