[Notes] [Git][BuildStream/buildstream][jjardon/ci_fedora28] dev-requirements.txt: Remove obsolete comments

[Javier Jardón <gitlab mg gitlab com>]

Title: GitLab

Javier Jardón pushed to branch jjardon/ci_fedora28 at BuildStream / buildstream

Commits:

• 1819a288
  by Javier Jardón at 2018-08-12T03:37:04Z

  dev-requirements.txt: Remove obsolete comments
  
  This also fixes an error with pylint in setup.py:
  setup.py:226:19: R1718: Consider using a set comprehension (consider-using-set-comprehension)
  

2 changed files:

• dev-requirements.txt
• setup.py

Changes:

dev-requirements.txt

---

1		-# Pin coverage to 4.2 for now, we're experiencing
2		-# random crashes with 4.4.2
3	1	coverage == 4.4.0
4	2	pep8
5	3	pytest >= 3.1.0
...	...	@@ -8,5 +6,4 @@ pytest-datafiles
8	6	pytest-env
9	7	pytest-pep8
10	8	pytest-pylint
11		-# Provide option to run tests in parallel, less reliable
12	9	pytest-xdist

setup.py

---

...	...	@@ -221,10 +221,8 @@ def get_cmdclass():
221	221	#####################################################
222	222	# Gather requirements #
223	223	#####################################################
224		-setup_requires = set(['pytest-runner'])
225	224	with open('dev-requirements.txt') as dev_reqs:
226		- dev_requires = set([line for line in dev_reqs.read().split('\n')
227		- if not line.strip().startswith('#')])
	225	+ dev_requires = dev_reqs.read().splitlines()
228	226
229	227
230	228	#####################################################
...	...	@@ -269,6 +267,6 @@ setup(name='BuildStream',
269	267	'grpcio >= 1.10',
270	268	],
271	269	entry_points=bst_install_entry_points,
272		- setup_requires=list(setup_requires),
273		- tests_require=list(dev_requires - setup_requires),
	270	+ setup_requires=['pytest-runner'],
	271	+ tests_require=dev_requires,
274	272	zip_safe=False)

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.