[Notes] [Git][BuildStream/buildstream][valentindavid/faster

Valentin David pushed to branch valentindavid/faster_startup-1.2 at BuildStream / buildstream

Commits:

83f4403d

by Valentin David at 2018-08-20T15:39:06Z

Fix broken indentation after tracking.

Issue was introduced by 171e803f (include directive) and the fix was
found courtesy of @Qinusty. This fixes also the include
feature. Because elements are to be serialized, the included fragments
need to use copy_tree when loaded.

Related to #470.

d25b7d77

by Valentin David at 2018-08-20T15:39:07Z

buildstream/_includes.py: Fix caching of included fragments.

ce6d5f8c

by Valentin David at 2018-08-20T17:02:58Z

Merge branch 'valentindavid/fix-broken-indentation-after-track-1.2' into 'bst-1.2'

Fix broken indentation after track

See merge request BuildStream/buildstream!687

24da69cf

by Chandan Singh at 2018-08-21T12:30:07Z

.gitlab-ci.yml: Bump tags for testsuite images

These new images come with pinned versions of `pytest` and `pylint`:

- `pylint`: `== 2.1.1`
- `pytest`: `>= 3.7`

54d15225

by Chandan Singh at 2018-08-21T12:30:13Z

dev-requirements.txt: Pin versions of pytest and pylint

These packages should only be updated as a deliberate change and the
code should be tested with the new versions to ensure that the test
still pass.

Any future updates should also happen in sync with the
buildstream-docker-images repository so that the testsuite base images
also enforce the same restrictions for the development requirements.

Replaces https://gitlab.com/BuildStream/buildstream/merge_requests/684.

be7533ab

by Chandan Singh at 2018-08-21T13:31:52Z

Merge branch 'chandan/update-ci-tags-1.2' into 'bst-1.2'

Restrict pylint/pytest versions and bump CI tags

See merge request BuildStream/buildstream!690

1be685a7

by Tristan Van Berkom at 2018-08-21T13:43:27Z

_frontend/linuxapp.py: Fix special casing around desktop notification escape sequence

Now we allow the notification to happen on any TERM
which starts with 'xterm' or 'vte', and we only do it
if the VTE_VERSION is >= 4600, where we know for sure that
VTE will not print garbage on the terminal.

Fixes #385

fc3cff95

by Tristan Van Berkom at 2018-08-21T15:44:21Z

Merge branch 'tristan/notifications-1.2' into 'bst-1.2'

_frontend/linuxapp.py: Fix special casing around desktop notification escape sequence

See merge request BuildStream/buildstream!693

6f6a04a9

by Jonathan Maw at 2018-08-22T05:54:45Z

Pipeline: Skip except_elements logic if no elements to except

1d48dee9

by Tristan Van Berkom at 2018-08-22T06:51:51Z

Merge branch 'jonathan/faster-except-elements-1.2' into 'bst-1.2'

Pipeline: Skip except_elements logic if no elements to except

See merge request BuildStream/buildstream!691

a4a8e5ab

by William Salmon at 2018-08-22T08:07:03Z

Catch Non Numeric versions

This patch just displays a better message than the default stack trace
but dose not try to fix the problem. A further patch will be created but
it effects versioneer so may take longer to land as it may need to go
via versioneer mainline.

3747f5d1

by William Salmon at 2018-08-22T08:07:03Z

Search for tags with the *.*.* patten for version

This has been done in a way that I hope might be able to be upstreamed
in to versioneer. This is not garanteed but it would be good if it
could be.

Please see https://github.com/warner/python-versioneer/pull/186 and
https://github.com/wsalmonct/python-versioneer/tree/feature/regexTags
for further details.

794b73e3

by Will Salmon at 2018-08-22T09:31:24Z

Merge branch 'willsalmon/MR601-backport' into 'bst-1.2'

Willsalmon/mr601 backport

See merge request BuildStream/buildstream!696

65cdd6dc

by Chandan Singh at 2018-08-22T10:08:52Z

setup.py: Add fields required for publishing on PyPi

Fill out those fields in `setup.py` that are required for publishing a
package on PyPi.

Part of https://gitlab.com/BuildStream/buildstream/issues/587.

2872bc6d

by Chandan Singh at 2018-08-22T11:11:36Z

Merge branch 'chandan/pypi-prep-1.2' into 'bst-1.2'

setup.py: Add fields required for publishing on PyPi

See merge request BuildStream/buildstream!699

452f6af6

by Jonathan Maw at 2018-08-22T11:25:23Z

Use ArtifactCache's get_cache_size when calculating the quota

It would have been more convenient to store the quota size in the
ArtifactCache, except that the scheduler needs the quota size and
doesn't have access to the ArtifactCache.

Changes:

.gitlab-ci.yml

 -image: buildstream/testsuite-debian:9-master-112-a9f63c5e
 +image: buildstream/testsuite-debian:9-master-114-4cab18e3
  cache:
    key: "$CI_JOB_NAME-"
@@ -89,25 +89,25 @@ source_dist:
      - coverage-linux/
  tests-debian-9:
 -  image: buildstream/testsuite-debian:9-master-112-a9f63c5e
 +  image: buildstream/testsuite-debian:9-master-114-4cab18e3
    <<: *linux-tests
  tests-fedora-27:
 -  image: buildstream/testsuite-fedora:27-master-112-a9f63c5e
 +  image: buildstream/testsuite-fedora:27-master-114-4cab18e3
    <<: *linux-tests
  tests-fedora-28:
 -  image: buildstream/testsuite-fedora:28-master-112-a9f63c5e
 +  image: buildstream/testsuite-fedora:28-master-114-4cab18e3
    <<: *linux-tests
  tests-ubuntu-18.04:
 -  image: buildstream/testsuite-ubuntu:18.04-master-112-a9f63c5e
 +  image: buildstream/testsuite-ubuntu:18.04-master-114-4cab18e3
    <<: *linux-tests
  tests-unix:
    # Use fedora here, to a) run a test on fedora and b) ensure that we
    # can get rid of ostree - this is not possible with debian-8
 -  image: buildstream/testsuite-fedora:27-master-112-a9f63c5e
 +  image: buildstream/testsuite-fedora:27-master-114-4cab18e3
    stage: test
    variables:
      BST_FORCE_BACKEND: "unix"

buildstream/_context.py

@@ -124,6 +124,8 @@ class Context():
          self._workspaces = None
          self._log_handle = None
          self._log_filename = None
 +        self._config_cache_quota = None
 +        self._artifactdir_volume = None
      # load()
+     #
@@ -187,67 +189,19 @@ class Context():
          while not os.path.exists(artifactdir_volume):
              artifactdir_volume = os.path.dirname(artifactdir_volume)
 +        self._artifactdir_volume = artifactdir_volume
++
          # We read and parse the cache quota as specified by the user
          cache_quota = _yaml.node_get(cache, str, 'quota', default_value='infinity')
          try:
 -            cache_quota = utils._parse_size(cache_quota, artifactdir_volume)
 +            cache_quota = utils._parse_size(cache_quota, self._artifactdir_volume)
          except utils.UtilError as e:
              raise LoadError(LoadErrorReason.INVALID_DATA,
                              "{}\nPlease specify the value in bytes or as a % of full disk space.\n"
                              "\nValid values are, for example: 800M 10G 1T 50%\n"
                              .format(str(e))) from e
 -        # Headroom intended to give BuildStream a bit of leeway.
 -        # This acts as the minimum size of cache_quota and also
 -        # is taken from the user requested cache_quota.
 -        #
 -        if 'BST_TEST_SUITE' in os.environ:
 -            headroom = 0
 -        else:
 -            headroom = 2e9
+-
 -        stat = os.statvfs(artifactdir_volume)
 -        available_space = (stat.f_bsize * stat.f_bavail)
+-
 -        # Again, the artifact directory may not yet have been created yet
 -        #
 -        if not os.path.exists(self.artifactdir):
 -            cache_size = 0
 -        else:
 -            cache_size = utils._get_dir_size(self.artifactdir)
+-
 -        # Ensure system has enough storage for the cache_quota
 -        #
 -        # If cache_quota is none, set it to the maximum it could possibly be.
 -        #
 -        # Also check that cache_quota is atleast as large as our headroom.
 -        #
 -        if cache_quota is None:  # Infinity, set to max system storage
 -            cache_quota = cache_size + available_space
 -        if cache_quota < headroom:  # Check minimum
 -            raise LoadError(LoadErrorReason.INVALID_DATA,
 -                            "Invalid cache quota ({}): ".format(utils._pretty_size(cache_quota)) +
 -                            "BuildStream requires a minimum cache quota of 2G.")
 -        elif cache_quota > cache_size + available_space:  # Check maximum
 -            raise LoadError(LoadErrorReason.INVALID_DATA,
 -                            ("Your system does not have enough available " +
 -                             "space to support the cache quota specified.\n" +
 -                             "You currently have:\n" +
 -                             "- {used} of cache in use at {local_cache_path}\n" +
 -                             "- {available} of available system storage").format(
 -                                 used=utils._pretty_size(cache_size),
 -                                 local_cache_path=self.artifactdir,
 -                                 available=utils._pretty_size(available_space)))
+-
 -        # Place a slight headroom (2e9 (2GB) on the cache_quota) into
 -        # cache_quota to try and avoid exceptions.
 -        #
 -        # Of course, we might still end up running out during a build
 -        # if we end up writing more than 2G, but hey, this stuff is
 -        # already really fuzzy.
 -        #
 -        self.cache_quota = cache_quota - headroom
 -        self.cache_lower_threshold = self.cache_quota / 2
 +        self._config_cache_quota = cache_quota
          # Load artifact share configuration
          self.artifact_cache_specs = ArtifactCache.specs_from_config_node(defaults)
@@ -571,6 +525,53 @@ class Context():
      def get_log_filename(self):
          return self._log_filename
 +    def set_cache_quota(self, cache_size):
 +        # Headroom intended to give BuildStream a bit of leeway.
 +        # This acts as the minimum size of cache_quota and also
 +        # is taken from the user requested cache_quota.
 +        #
 +        if 'BST_TEST_SUITE' in os.environ:
 +            headroom = 0
 +        else:
 +            headroom = 2e9
++
 +        stat = os.statvfs(self._artifactdir_volume)
 +        available_space = (stat.f_bsize * stat.f_bavail)
++
 +        # Ensure system has enough storage for the cache_quota
 +        #
 +        # If cache_quota is none, set it to the maximum it could possibly be.
 +        #
 +        # Also check that cache_quota is atleast as large as our headroom.
 +        #
 +        cache_quota = self._config_cache_quota
 +        if cache_quota is None:  # Infinity, set to max system storage
 +            cache_quota = cache_size + available_space
 +        if cache_quota < headroom:  # Check minimum
 +            raise LoadError(LoadErrorReason.INVALID_DATA,
 +                            "Invalid cache quota ({}): ".format(utils._pretty_size(cache_quota)) +
 +                            "BuildStream requires a minimum cache quota of 2G.")
 +        elif cache_quota > cache_size + available_space:  # Check maximum
 +            raise LoadError(LoadErrorReason.INVALID_DATA,
 +                            ("Your system does not have enough available " +
 +                             "space to support the cache quota specified.\n" +
 +                             "You currently have:\n" +
 +                             "- {used} of cache in use at {local_cache_path}\n" +
 +                             "- {available} of available system storage").format(
 +                                 used=utils._pretty_size(cache_size),
 +                                 local_cache_path=self.artifactdir,
 +                                 available=utils._pretty_size(available_space)))
++
 +        # Place a slight headroom (2e9 (2GB) on the cache_quota) into
 +        # cache_quota to try and avoid exceptions.
 +        #
 +        # Of course, we might still end up running out during a build
 +        # if we end up writing more than 2G, but hey, this stuff is
 +        # already really fuzzy.
 +        #
 +        self.cache_quota = cache_quota - headroom
 +        self.cache_lower_threshold = self.cache_quota / 2
++
      # _record_message()
+     #
      # Records the message if recording is enabled

buildstream/_frontend/app.py

@@ -202,6 +202,10 @@ class App():
          Platform.create_instance(self.context)
 +        platform = Platform.get_platform()
 +        cache_size = platform._artifact_cache.calculate_cache_size()
 +        self.context.set_cache_quota(cache_size)
++
          # Create the logger right before setting the message handler
          self.logger = LogLine(self.context,
                                self._content_profile,

buildstream/_frontend/linuxapp.py

@@ -22,12 +22,43 @@ import click
  from .app import App
 +# This trick is currently only supported on some terminals,
 +# avoid using it where it can cause garbage to be printed
 +# to the terminal.
 +#
 +def _osc_777_supported():
++
 +    term = os.environ['TERM']
++
 +    if term.startswith('xterm') or term.startswith('vte'):
++
 +        # Since vte version 4600, upstream silently ignores
 +        # the OSC 777 without printing garbage to the terminal.
 +        #
 +        # For distros like Fedora who have patched vte, this
 +        # will trigger a desktop notification and bring attention
 +        # to the terminal.
 +        #
 +        vte_version = os.environ['VTE_VERSION']
 +        try:
 +            vte_version_int = int(vte_version)
 +        except ValueError:
 +            return False
++
 +        if vte_version_int >= 4600:
 +            return True
++
 +    return False
++
++
  # A linux specific App implementation
+ #
  class LinuxApp(App):
      def notify(self, title, text):
 -        term = os.environ['TERM']
 -        if term in ('xterm', 'vte'):
 -            click.echo("\033]777;notify;{};{}\007".format(title, text))
 +        # Currently we only try this notification method
 +        # of sending an escape sequence to the terminal
 +        #
 +        if _osc_777_supported():
 +            click.echo("\033]777;notify;{};{}\007".format(title, text), err=True)

buildstream/_includes.py

@@ -10,11 +10,15 @@ from ._exceptions import LoadError, LoadErrorReason
+ #
  # Args:
  #    loader (Loader): The Loader object
 +#    copy_tree (bool): Whether to make a copy, of tree in
 +#                      provenance. Should be true if intended to be
 +#                      serialized.
  class Includes:
 -    def __init__(self, loader):
 +    def __init__(self, loader, *, copy_tree=False):
          self._loader = loader
          self._loaded = {}
 +        self._copy_tree = copy_tree
      # process()
+     #
@@ -96,10 +100,11 @@ class Includes:
          directory = project.directory
          file_path = os.path.join(directory, include)
          key = (current_loader, file_path)
 -        if file_path not in self._loaded:
 +        if key not in self._loaded:
              self._loaded[key] = _yaml.load(os.path.join(directory, include),
                                             shortname=shortname,
 -                                           project=project)
 +                                           project=project,
 +                                           copy_tree=self._copy_tree)
          return self._loaded[key], file_path, current_loader
      # _process_value()

buildstream/_loader/loader.py

@@ -78,7 +78,7 @@ class Loader():
          self._elements = {}       # Dict of elements
          self._loaders = {}        # Dict of junction loaders
 -        self._includes = Includes(self)
 +        self._includes = Includes(self, copy_tree=True)
      # load():
+     #

buildstream/_pipeline.py

@@ -235,6 +235,9 @@ class Pipeline():
      #                       exceptions removed
+     #
      def except_elements(self, targets, elements, except_targets):
 +        if not except_targets:
 +            return elements
++
          targeted = list(self.dependencies(targets, Scope.ALL))
          visited = []

buildstream/_project.py

@@ -416,7 +416,7 @@ class Project():
                               parent=parent_loader,
                               tempdir=tempdir)
 -        self._project_includes = Includes(self.loader)
 +        self._project_includes = Includes(self.loader, copy_tree=False)
          project_conf_first_pass = _yaml.node_copy(self._project_conf)
          self._project_includes.process(project_conf_first_pass, only_local=True)

buildstream/_version.py

@@ -43,6 +43,7 @@ def get_config():
      cfg.VCS = "git"
      cfg.style = "pep440"
      cfg.tag_prefix = ""
 +    cfg.tag_regex = "*.*.*"
      cfg.parentdir_prefix = "BuildStream-"
      cfg.versionfile_source = "buildstream/_version.py"
      cfg.verbose = False
@@ -215,7 +216,7 @@ def git_versions_from_keywords(keywords, tag_prefix, verbose):
  @register_vcs_handler("git", "pieces_from_vcs")
 -def git_pieces_from_vcs(tag_prefix, root, verbose, run_command=run_command):
 +def git_pieces_from_vcs(tag_prefix, tag_regex, root, verbose, run_command=run_command):
      """Get version from 'git describe' in the root of the source tree.
      This only gets called if the git-archive 'subst' keywords were *not*
@@ -237,7 +238,7 @@ def git_pieces_from_vcs(tag_prefix, root, verbose, run_command=run_command):
      # if there isn't one, this yields HEX[-dirty] (no NUM)
      describe_out, rc = run_command(GITS, ["describe", "--tags", "--dirty",
                                            "--always", "--long",
 -                                          "--match", "%s*" % tag_prefix],
 +                                          "--match", "%s%s" % (tag_prefix, tag_regex)],
                                     cwd=root)
      # --long was added in git-1.5.5
      if describe_out is None:
@@ -505,7 +506,7 @@ def get_versions():
                  "date": None}
      try:
 -        pieces = git_pieces_from_vcs(cfg.tag_prefix, root, verbose)
 +        pieces = git_pieces_from_vcs(cfg.tag_prefix, cfg.tag_regex, root, verbose)
          return render(pieces, cfg.style)
      except NotThisMethod:
          pass

buildstream/source.py

@@ -752,7 +752,7 @@ class Source(Plugin):
                  # Save the ref in the originating file
+                 #
                  try:
 -                    _yaml.dump(_yaml.node_sanitize(provenance.toplevel), provenance.filename.name)
 +                    _yaml.dump(provenance.toplevel, provenance.filename.name)
                  except OSError as e:
                      raise SourceError("{}: Error saving source reference to '{}': {}"
                                        .format(self, provenance.filename.name, e),

buildstream/utils.py

@@ -481,7 +481,16 @@ def get_bst_version():
          raise UtilError("Your git repository has no tags - BuildStream can't "
                          "determine its version. Please run `git fetch --tags`.")
 -    return (int(versions[0]), int(versions[1]))
 +    try:
 +        return (int(versions[0]), int(versions[1]))
 +    except IndexError:
 +        raise UtilError("Cannot detect Major and Minor parts of the version\n"
 +                        "Version: {} not in XX.YY.whatever format"
 +                        .format(__version__))
 +    except ValueError:
 +        raise UtilError("Cannot convert version to integer numbers\n"
 +                        "Version: {} not in Integer.Integer.whatever format"
 +                        .format(__version__))
  @contextmanager

dev-requirements.txt

  coverage == 4.4.0
  pep8
 -pytest >= 3.1.0
 +pylint == 2.1.1
 +pytest >= 3.7
  pytest-cov >= 2.5.0
  pytest-datafiles
  pytest-env

setup.cfg

@@ -4,6 +4,7 @@ style = pep440
  versionfile_source = buildstream/_version.py
  versionfile_build = buildstream/_version.py
  tag_prefix =
 +tag_regex = *.*.*
  parentdir_prefix = BuildStream-
  [aliases]

setup.py

@@ -224,6 +224,13 @@ def get_cmdclass():
  with open('dev-requirements.txt') as dev_reqs:
      dev_requires = dev_reqs.read().splitlines()
 +#####################################################
 +#     Prepare package description from README       #
 +#####################################################
 +with open(os.path.join(os.path.dirname(os.path.realpath(__file__)),
 +                       'README.rst')) as readme:
 +    long_description = readme.read()
++
  #####################################################
  #             Main setup() Invocation               #
@@ -233,8 +240,13 @@ setup(name='BuildStream',
        version=versioneer.get_version(),
        cmdclass=get_cmdclass(),
 +      author='BuildStream Developers',
 +      author_email='buildstream-list gnome org',
        description='A framework for modelling build pipelines in YAML',
        license='LGPL',
 +      long_description=long_description,
 +      long_description_content_type='text/x-rst; charset=UTF-8',
 +      url='https://gitlab.com/BuildStream/buildstream',
        packages=find_packages(exclude=('tests', 'tests.*')),
        package_data={'buildstream': ['plugins/*/*.py', 'plugins/*/*.yaml',
                                      'data/*.yaml', 'data/*.sh.in']},

versioneer.py

@@ -355,6 +355,7 @@ def get_config_from_root(root):
      cfg.versionfile_source = get(parser, "versionfile_source")
      cfg.versionfile_build = get(parser, "versionfile_build")
      cfg.tag_prefix = get(parser, "tag_prefix")
 +    cfg.tag_regex = get(parser, "tag_regex") or "*"
      if cfg.tag_prefix in ("''", '""'):
          cfg.tag_prefix = ""
      cfg.parentdir_prefix = get(parser, "parentdir_prefix")
@@ -463,6 +464,7 @@ def get_config():
      cfg.VCS = "git"
      cfg.style = "%(STYLE)s"
      cfg.tag_prefix = "%(TAG_PREFIX)s"
 +    cfg.tag_regex = "%(TAG_REGEX)s"
      cfg.parentdir_prefix = "%(PARENTDIR_PREFIX)s"
      cfg.versionfile_source = "%(VERSIONFILE_SOURCE)s"
      cfg.verbose = False
@@ -635,7 +637,7 @@ def git_versions_from_keywords(keywords, tag_prefix, verbose):
  @register_vcs_handler("git", "pieces_from_vcs")
 -def git_pieces_from_vcs(tag_prefix, root, verbose, run_command=run_command):
 +def git_pieces_from_vcs(tag_prefix, tag_regex, root, verbose, run_command=run_command):
      """Get version from 'git describe' in the root of the source tree.
      This only gets called if the git-archive 'subst' keywords were *not*
@@ -657,7 +659,7 @@ def git_pieces_from_vcs(tag_prefix, root, verbose, run_command=run_command):
      # if there isn't one, this yields HEX[-dirty] (no NUM)
      describe_out, rc = run_command(GITS, ["describe", "--tags", "--dirty",
                                            "--always", "--long",
 -                                          "--match", "%%s*" %% tag_prefix],
 +                                          "--match", "%%s%%s" %% (tag_prefix, tag_regex)],
                                     cwd=root)
      # --long was added in git-1.5.5
      if describe_out is None:
@@ -925,7 +927,7 @@ def get_versions():
                  "date": None}
      try:
 -        pieces = git_pieces_from_vcs(cfg.tag_prefix, root, verbose)
 +        pieces = git_pieces_from_vcs(cfg.tag_prefix, cfg.tag_regex, root, verbose)
          return render(pieces, cfg.style)
      except NotThisMethod:
          pass
@@ -1027,7 +1029,7 @@ def git_versions_from_keywords(keywords, tag_prefix, verbose):
  @register_vcs_handler("git", "pieces_from_vcs")
 -def git_pieces_from_vcs(tag_prefix, root, verbose, run_command=run_command):
 +def git_pieces_from_vcs(tag_prefix, tag_regex, root, verbose, run_command=run_command):
      """Get version from 'git describe' in the root of the source tree.
      This only gets called if the git-archive 'subst' keywords were *not*
@@ -1049,7 +1051,7 @@ def git_pieces_from_vcs(tag_prefix, root, verbose, run_command=run_command):
      # if there isn't one, this yields HEX[-dirty] (no NUM)
      describe_out, rc = run_command(GITS, ["describe", "--tags", "--dirty",
                                            "--always", "--long",
 -                                          "--match", "%s*" % tag_prefix],
 +                                          "--match", "%s%s" % (tag_prefix, tag_regex)],
                                     cwd=root)
      # --long was added in git-1.5.5
      if describe_out is None:
@@ -1451,7 +1453,7 @@ def get_versions(verbose=False):
      from_vcs_f = handlers.get("pieces_from_vcs")
      if from_vcs_f:
          try:
 -            pieces = from_vcs_f(cfg.tag_prefix, root, verbose)
 +            pieces = from_vcs_f(cfg.tag_prefix, cfg.tag_regex, root, verbose)
              ver = render(pieces, cfg.style)
              if verbose:
                  print("got version from VCS %s" % ver)
@@ -1586,6 +1588,7 @@ def get_cmdclass():
                              {"DOLLAR": "$",
                               "STYLE": cfg.style,
                               "TAG_PREFIX": cfg.tag_prefix,
 +                             "TAG_REGEX": cfg.tag_regex,
                               "PARENTDIR_PREFIX": cfg.parentdir_prefix,
                               "VERSIONFILE_SOURCE": cfg.versionfile_source,
                               })
@@ -1615,6 +1618,7 @@ def get_cmdclass():
                              {"DOLLAR": "$",
                               "STYLE": cfg.style,
                               "TAG_PREFIX": cfg.tag_prefix,
 +                             "TAG_REGEX": cfg.tag_regex,
                               "PARENTDIR_PREFIX": cfg.parentdir_prefix,
                               "VERSIONFILE_SOURCE": cfg.versionfile_source,
                               })
@@ -1716,6 +1720,7 @@ def do_setup():
          f.write(LONG % {"DOLLAR": "$",
                          "STYLE": cfg.style,
                          "TAG_PREFIX": cfg.tag_prefix,
 +                        "TAG_REGEX": cfg.tag_regex,
                          "PARENTDIR_PREFIX": cfg.parentdir_prefix,
                          "VERSIONFILE_SOURCE": cfg.versionfile_source,
                          })

[Notes] [Git][BuildStream/buildstream][valentindavid/faster_startup-1.2] 16 commits: Fix broken indentation after tracking.

Valentin David pushed to branch valentindavid/faster_startup-1.2 at BuildStream / buildstream

Commits:

15 changed files:

Changes: