[Notes] [Git][BuildStream/buildstream][master] 2 commits: app.py: Handle exception thrown when recursion limit is exceeded

[Agustin Benito Bethencourt <gitlab mg gitlab com>]

Title: GitLab

Agustin Benito Bethencourt pushed to branch master at BuildStream / buildstream

Commits:

• 95b4eae4
  by Phil Dawson at 2018-07-25T13:03:23Z

  app.py: Handle exception thrown when recursion limit is exceeded
  
  Because the RecursionError exception was introduced in Python 3.5, until we
  drop support for for Python 3.4, we must use RuntimeError.
  

• 889bf238
  by Jim MacArthur at 2018-07-25T13:43:21Z

  Merge branch 'phil/203-BuildStream-crashes-when-dependency-tree-too-deep' into 'master'
  
  Phil/203 BuildStream crashes when dependency tree too deep
  
  See merge request BuildStream/buildstream!512

1 changed file:

• buildstream/_frontend/app.py

Changes:

buildstream/_frontend/app.py

---

...	...	@@ -270,6 +270,10 @@ class App():
270	270
271	271	# Exit with the error
272	272	self._error_exit(e)
	273	+ except RecursionError:
	274	+ click.echo("RecursionError: Depency depth is too large. Maximum recursion depth exceeded.",
	275	+ err=True)
	276	+ sys.exit(-1)
273	277
274	278	else:
275	279	# No exceptions occurred, print session time and summary

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.