[Notes] [Git][BuildStream/buildstream][Qinusty/502] cascache.py: Raise ArtifactError on grpc error

[Qinusty <gitlab mg gitlab com>]

Title: GitLab

Qinusty pushed to branch Qinusty/502 at BuildStream / buildstream

Commits:

• b60e0396
  by Josh Smith at 2018-07-27T08:24:38Z

  cascache.py: Raise ArtifactError on grpc error
  
  This aims to fix issue #502.
  

1 changed file:

• buildstream/_artifactcache/cascache.py

Changes:

buildstream/_artifactcache/cascache.py

---

...	...	@@ -240,7 +240,7 @@ class CASCache(ArtifactCache):
240	240
241	241	except grpc.RpcError as e:
242	242	if e.code() != grpc.StatusCode.NOT_FOUND:
243		- raise
	243	+ raise ArtifactError("Failed to pull artifact {}: {}".format(element._get_brief_display_key(), e))
244	244
245	245	return False
246	246
...	...	@@ -285,6 +285,7 @@ class CASCache(ArtifactCache):
285	285
286	286	except grpc.RpcError as e:
287	287	if e.code() != grpc.StatusCode.NOT_FOUND:
	288	+ # Intentionally re-raise RpcError for outer except block.
288	289	raise
289	290
290	291	missing_blobs = {}

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.