[Notes] [Git][BuildStream/buildstream][master] 2 commits: BREAK: manual.yaml: don't set any default env vars

[Tristan Van Berkom <gitlab mg gitlab com>]

Title: GitLab

Tristan Van Berkom pushed to branch master at BuildStream / buildstream

Commits:

• 4cfabce8
  by Angelos Evripiotis at 2018-11-01T11:35:02Z

  BREAK: manual.yaml: don't set any default env vars
  
  Remove the 'MAKEFLAGS' and 'V' defaults.
  
  Now that there is a specialised 'make' element, these make-specific
  defaults don't make sense here. This element is meant to be a blank
  slate for folks to build on.
  
  Note that this is a breaking change, that will require some users to
  make changes to their .bst files if they are expecting these environment
  variable to be set.
  
  _versions.py: BST_FORMAT_VERSION bumped to 18.
  
  This fixes issue #718
  

• 48860aac
  by Tristan Van Berkom at 2018-11-01T12:01:04Z

  Merge branch 'tristan/empty-manual-element' into 'master'
  
  BREAK: manual.yaml: don't set any default env vars
  
  Closes #718
  
  See merge request BuildStream/buildstream!916

3 changed files:

• NEWS
• buildstream/_versions.py
• buildstream/plugins/elements/manual.yaml

Changes:

NEWS

---

...	...	@@ -2,6 +2,12 @@
2	2	buildstream 1.3.1
3	3	=================
4	4
	5	+ o BREAKING CHANGE: The 'manual' element lost its default 'MAKEFLAGS' and 'V'
	6	+ environment variables. There is already a 'make' element with the same
	7	+ variables. Note that this is a breaking change, it will require users to
	8	+ make changes to their .bst files if they are expecting these environment
	9	+ variables to be set.
	10	+
5	11	o Failed builds are included in the cache as well.
6	12	`bst checkout` will provide anything in `%{install-root}`.
7	13	A build including cached fails will cause any dependant elements

buildstream/_versions.py

---

...	...	@@ -23,7 +23,7 @@
23	23	# This version is bumped whenever enhancements are made
24	24	# to the `project.conf` format or the core element format.
25	25	#
26		-BST_FORMAT_VERSION = 17
	26	+BST_FORMAT_VERSION = 18
27	27
28	28
29	29	# The base BuildStream artifact version

buildstream/plugins/elements/manual.yaml

---

1		-# No variables added for the manual element by default, set
2		-# this if you plan to use make, and the sources cannot handle
3		-# parallelization.
4		-#
5		-# variables:
6		-#
7		-# notparallel: True
8		-
9	1	# Manual build element does not provide any default
10	2	# build commands
11	3	config:
...	...	@@ -28,14 +20,3 @@ config:
28	20	strip-commands:
29	21	- |
30	22	%{strip-binaries}
31		-
32		-# Use max-jobs CPUs for building and enable verbosity
33		-environment:
34		- MAKEFLAGS: -j%{max-jobs}
35		- V: 1
36		-
37		-# And dont consider MAKEFLAGS or V as something which may
38		-# affect build output.
39		-environment-nocache:
40		-- MAKEFLAGS
41		-- V

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.