[Notes] [Git][BuildStream/buildstream][valentindavid/remote_execution_configuration] Deleted 1 commit: Allow selecting user or project configuration for remote execution
- From: Valentin David <gitlab mg gitlab com>
- To: buildstream-notifications-list gnome org
- Subject: [Notes] [Git][BuildStream/buildstream][valentindavid/remote_execution_configuration] Deleted 1 commit: Allow selecting user or project configuration for remote execution
- Date: Wed, 02 Jan 2019 11:40:48 +0000
Title: 
GitLab
Valentin David pushed to branch valentindavid/remote_execution_configuration
at BuildStream / buildstream
WARNING:
The push did not contain any new commits, but force pushed to delete the commits and changes below.
Deleted commits:
5 changed files:
Changes:
buildstream/_context.py
| ... | ... | @@ -121,6 +121,9 @@ class Context(): | 
| 121 | 121 |          # Whether or not to attempt to pull build trees globally
 | 
| 122 | 122 |          self.pull_buildtrees = None
 | 
| 123 | 123 |  
 | 
|  | 124 | +        # Which configured remote execution server to use
 | 
|  | 125 | +        self.remote_execution = 'any'
 | 
|  | 126 | +
 | 
| 124 | 127 |          # Boolean, whether we double-check with the user that they meant to
 | 
| 125 | 128 |          # remove a workspace directory.
 | 
| 126 | 129 |          self.prompt_workspace_close_remove_dir = None
 | 
buildstream/_frontend/app.py
| ... | ... | @@ -183,7 +183,8 @@ class App(): | 
| 183 | 183 |              'builders': 'sched_builders',
 | 
| 184 | 184 |              'pushers': 'sched_pushers',
 | 
| 185 | 185 |              'network_retries': 'sched_network_retries',
 | 
| 186 |  | -            'pull_buildtrees': 'pull_buildtrees'
 | 
|  | 186 | +            'pull_buildtrees': 'pull_buildtrees',
 | 
|  | 187 | +            'remote_execution': 'remote_execution'
 | 
| 187 | 188 |          }
 | 
| 188 | 189 |          for cli_option, context_attr in override_map.items():
 | 
| 189 | 190 |              option_value = self._main_options.get(cli_option)
 | 
buildstream/_frontend/cli.py
| ... | ... | @@ -239,6 +239,9 @@ def print_version(ctx, param, value): | 
| 239 | 239 |                help="The mirror to fetch from first, before attempting other mirrors")
 | 
| 240 | 240 |  @click.option('--pull-buildtrees', is_flag=True, default=None,
 | 
| 241 | 241 |                help="Include an element's build tree when pulling remote element artifacts")
 | 
|  | 242 | +@click.option('--remote-execution', default='any',
 | 
|  | 243 | +              type=click.Choice(['any', 'user', 'project', 'none']),
 | 
|  | 244 | +              help='Select which remote execution server to use')
 | 
| 242 | 245 |  @click.pass_context
 | 
| 243 | 246 |  def cli(context, **kwargs):
 | 
| 244 | 247 |      """Build and manipulate BuildStream projects
 | 
buildstream/_project.py
| ... | ... | @@ -511,12 +511,23 @@ class Project(): | 
| 511 | 511 |          override_specs = SandboxRemote.specs_from_config_node(
 | 
| 512 | 512 |              self._context.get_overrides(self.name), self.directory)
 | 
| 513 | 513 |  
 | 
| 514 |  | -        if override_specs is not None:
 | 
| 515 |  | -            self.remote_execution_specs = override_specs
 | 
| 516 |  | -        elif project_specs is not None:
 | 
|  | 514 | +        if self._context.remote_execution == 'any':
 | 
|  | 515 | +            if override_specs is not None:
 | 
|  | 516 | +                self.remote_execution_specs = override_specs
 | 
|  | 517 | +            elif project_specs is not None:
 | 
|  | 518 | +                self.remote_execution_specs = project_specs
 | 
|  | 519 | +            else:
 | 
|  | 520 | +                self.remote_execution_specs = self._context.remote_execution_specs
 | 
|  | 521 | +        elif self._context.remote_execution == 'user':
 | 
|  | 522 | +            if override_specs is not None:
 | 
|  | 523 | +                self.remote_execution_specs = override_specs
 | 
|  | 524 | +            else:
 | 
|  | 525 | +                self.remote_execution_specs = self._context.remote_execution_specs
 | 
|  | 526 | +        elif self._context.remote_execution == 'project':
 | 
| 517 | 527 |              self.remote_execution_specs = project_specs
 | 
| 518 | 528 |          else:
 | 
| 519 |  | -            self.remote_execution_specs = self._context.remote_execution_specs
 | 
|  | 529 | +            assert self._context.remote_execution == 'none'
 | 
|  | 530 | +            self.remote_execution_specs = None
 | 
| 520 | 531 |  
 | 
| 521 | 532 |          # Load sandbox environment variables
 | 
| 522 | 533 |          self.base_environment = _yaml.node_get(config, Mapping, 'environment')
 | 
tests/completions/completions.py
| ... | ... | @@ -42,6 +42,7 @@ MAIN_OPTIONS = [ | 
| 42 | 42 |      "--option ",
 | 
| 43 | 43 |      "--on-error ",
 | 
| 44 | 44 |      "--pull-buildtrees ",
 | 
|  | 45 | +    "--remote-execution ",
 | 
| 45 | 46 |      "--pushers ",
 | 
| 46 | 47 |      "--strict ",
 | 
| 47 | 48 |      "--verbose ",
 | 
 
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]