[Notes] [Git][BuildStream/buildstream][master] 2 commits: sandbox/sandbox.py: Fix regression of command logging

[Tristan Van Berkom <gitlab mg gitlab com>]

Title: GitLab

Tristan Van Berkom pushed to branch master at BuildStream / buildstream

Commits:

• 512c726e
  by Tristan Van Berkom at 2019-01-08T03:38:11Z

  sandbox/sandbox.py: Fix regression of command logging
  
  Since we added batch commands, the batch commands print the
  text of the commands directly in the message text, but this is wrong.
  
  The detail string is the appropriate place for text of unknown lengths
  (the user can actually configure how many max lines of commands they
  want to see in their log), the message text itself should be controlled
  and brief enough to avoid text wrapping.
  

• 01171988
  by Tristan Van Berkom at 2019-01-08T04:20:14Z

  Merge branch 'tristan/fix-command-status-messages' into 'master'
  
  sandbox/sandbox.py: Fix regression of command logging
  
  See merge request BuildStream/buildstream!1044

1 changed file:

• buildstream/sandbox/sandbox.py

Changes:

buildstream/sandbox/sandbox.py

---

...	...	@@ -592,7 +592,7 @@ class _SandboxBatch():
592	592	if command.label:
593	593	context = self.sandbox._get_context()
594	594	message = Message(self.sandbox._get_plugin_id(), MessageType.STATUS,
595		- 'Running {}'.format(command.label))
	595	+ 'Running command', detail=command.label)
596	596	context.message(message)
597	597
598	598	exitcode = self.sandbox._run(command.command, self.flags, cwd=command.cwd, env=command.env)

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.