[Notes] [Git][BuildStream/buildstream][bschubert/pipeline] Don't update state before summary. It should be consistent

[Benjamin Schubert <gitlab mg gitlab com>]

Title: GitLab

Benjamin Schubert pushed to branch bschubert/pipeline at BuildStream / buildstream

Commits:

• 132b8ffc
  by Benjamin Schubert at 2019-01-15T13:06:15Z

  Don't update state before summary. It should be consistent
  
  Since we know when an object's state can change, we don't need
  to update the state of all objects for consistency.
  

1 changed file:

• buildstream/_stream.py

Changes:

buildstream/_stream.py

---

...	...	@@ -28,7 +28,7 @@ import tarfile
28	28	import tempfile
29	29	from contextlib import contextmanager, suppress
30	30
31		-from ._exceptions import StreamError, ImplError, BstError, set_last_task_error
	31	+from ._exceptions import StreamError, ImplError, BstError
32	32	from ._message import Message, MessageType
33	33	from ._scheduler import Scheduler, SchedStatus, TrackQueue, FetchQueue, BuildQueue, PullQueue, PushQueue
34	34	from ._pipeline import Pipeline, PipelineSelection
...	...	@@ -1018,17 +1018,6 @@ class Stream():
1018	1018
1019	1019	_, status = self._scheduler.run(self.queues)
1020	1020
1021		- # Force update element states after a run, such that the summary
1022		- # is more coherent
1023		- try:
1024		- for element in self.total_elements:
1025		- element._update_state()
1026		- except BstError as e:
1027		- self._message(MessageType.ERROR, "Error resolving final state", detail=str(e))
1028		- set_last_task_error(e.domain, e.reason)
1029		- except Exception as e: # pylint: disable=broad-except
1030		- self._message(MessageType.BUG, "Unhandled exception while resolving final state", detail=str(e))
1031		-
1032	1021	if status == SchedStatus.ERROR:
1033	1022	raise StreamError()
1034	1023	elif status == SchedStatus.TERMINATED:

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.