[Notes] [Git][BuildStream/buildstream][chandan/import-is-not-buildelement] Derive import plugin from Element instead of BuildElement

[Chandan Singh <gitlab mg gitlab com>]

Title: GitLab

Chandan Singh pushed to branch chandan/import-is-not-buildelement at BuildStream / buildstream

Commits:

• 9d7c9c06
  by Chandan Singh at 2019-01-18T20:54:35Z

  Derive import plugin from Element instead of BuildElement
  
  The `import` element is not really a build element. The main purpose of
  the `BuildElement` class is to allow users to run `build-commands`,
  `install-commands` etc. But, `import` does not run such commands.
  Moreover, we already override all the methods provided by
  `BuildElement`. So it only makes it confusing to have it derived from
  `BuildElement` class when it is not a build element.
  
  So, derive it from the base `Element` class instead.
  

1 changed file:

• buildstream/plugins/elements/import.py

Changes:

buildstream/plugins/elements/import.py

---

...	...	@@ -28,17 +28,14 @@ some configuration data.
28	28	The empty configuration is as such:
29	29	.. literalinclude:: ../../../buildstream/plugins/elements/import.yaml
30	30	:language: yaml
31		-
32		-See :ref:`built-in functionality documentation <core_buildelement_builtins>` for
33		-details on common configuration options for build elements.
34	31	"""
35	32
36	33	import os
37		-from buildstream import Element, BuildElement, ElementError
	34	+from buildstream import Element, ElementError
38	35
39	36
40	37	# Element implementation for the 'import' kind.
41		-class ImportElement(BuildElement):
	38	+class ImportElement(Element):
42	39	# pylint: disable=attribute-defined-outside-init
43	40
44	41	# This plugin has been modified to avoid the use of Sandbox.get_directory
...	...	@@ -93,10 +90,6 @@ class ImportElement(BuildElement):
93	90	# And we're done
94	91	return '/output'
95	92
96		- def prepare(self, sandbox):
97		- # We inherit a non-default prepare from BuildElement.
98		- Element.prepare(self, sandbox)
99		-
100	93	def generate_script(self):
101	94	build_root = self.get_variable('build-root')
102	95	install_root = self.get_variable('install-root')

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.