[Notes] [Git][BuildStream/buildstream][master] 2 commits: Fix crash when spawned job completes very fast

[Jürg Billeter <gitlab mg gitlab com>]

Title: GitLab

Jürg Billeter pushed to branch master at BuildStream / buildstream

Commits:

• a1ab48da
  by Valentin David at 2019-01-28T21:30:26Z

  Fix crash when spawned job completes very fast
  
  Job can complete before we return from `Job.span()` to
  `Scheduler._spawn_job()`, so that `_active_jobs` would not yet contain
  the job.
  
  This would print a stack on the console and try to run a second time
  the job which can have unexpected effects.
  
  In order to reproduce the issue, in
  `buildstream/_scheduler/jobs/job.py`, in `Job.spawn`,
  add a call to `time.sleep()` right before call to
  `asyncio.get_child_watcher()`.
  
  This fixes issue #857.
  

• 2fcb4491
  by Jürg Billeter at 2019-01-28T22:36:22Z

  Merge branch 'valentindavid/crash_in_scheduler_857' into 'master'
  
  Fix crash when spawned job completes very fast
  
  Closes #857
  
  See merge request BuildStream/buildstream!1095

1 changed file:

• buildstream/_scheduler/scheduler.py

Changes:

buildstream/_scheduler/scheduler.py

---

...	...	@@ -314,10 +314,10 @@ class Scheduler():
314	314	# job (Job): The job to spawn
315	315	#
316	316	def _spawn_job(self, job):
317		- job.spawn()
318	317	self._active_jobs.append(job)
319	318	if self._job_start_callback:
320	319	self._job_start_callback(job)
	320	+ job.spawn()
321	321
322	322	# Callback for the cache size job
323	323	def _cache_size_job_complete(self, status, cache_size):

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.