banshee r2125 - in branches/banshee/rubenv: . src/Core/Banshee.Base src/Core/Banshee.Base/Banshee.SmartPlaylist src/Core/Banshee.Base/Sources src/Plugins/Banshee.Plugins.Podcast
- From: rubenv svn gnome org
- To: svn-commits-list gnome org
- Subject: banshee r2125 - in branches/banshee/rubenv: . src/Core/Banshee.Base src/Core/Banshee.Base/Banshee.SmartPlaylist src/Core/Banshee.Base/Sources src/Plugins/Banshee.Plugins.Podcast
- Date: Tue, 27 Feb 2007 16:18:47 +0000 (GMT)
Author: rubenv
Date: 2007-02-27 16:18:47 +0000 (Tue, 27 Feb 2007)
New Revision: 2125
ViewCVS link: http://svn.gnome.org/viewcvs/banshee?rev=2125&view=rev
Modified:
branches/banshee/rubenv/ChangeLog
branches/banshee/rubenv/src/Core/Banshee.Base/Banshee.SmartPlaylist/SmartPlaylistSource.cs
branches/banshee/rubenv/src/Core/Banshee.Base/Library.cs
branches/banshee/rubenv/src/Core/Banshee.Base/Sources/LibrarySource.cs
branches/banshee/rubenv/src/Core/Banshee.Base/Sources/PlaylistSource.cs
branches/banshee/rubenv/src/Plugins/Banshee.Plugins.Podcast/PodcastLibrary.cs
Log:
2007-02-27 Ruben Vermeersch <ruben savanne be>
Clean up LibraryTrackRemovedArgs.
This patch changes the definition of LibraryTrackRemovedArgs from
{ LibraryTrackInfo Track, ICollection Tracks }
to
{ ICollection<LibraryTrackInfo> Tracks }
This causes a couple of things:
The first goal was to simplify all methods handling
LibraryTrackRemovedArgs. Now they only have to handle the single Tracks
attribute. This removes a lot of duplicated code. Each method handling the
TrackRemoved signal basically had to implement itself twice, this has now
been reduced to once.
While working on this, I changed Tracks to be a generic class of
LibraryTrackInfo objects. This improves type safety. With the current
code, it was possible to have both LibraryTrackInfo objects and SafeUri
objects in the Tracks attribute. Fortunately, the possibility to use
SafeUris isn't used anywhere as no code implements functionality to handle
this.
* src/Core/Banshee.Base/Banshee.SmartPlaylist/SmartPlaylistSource.c
s:
* src/Core/Banshee.Base/Sources/LibrarySource.cs:
* src/Core/Banshee.Base/Sources/PlaylistSource.cs:
* src/Plugins/Banshee.Plugins.Podcast/PodcastLibrary.cs: Fixed methods
handling LibraryTrackRemovedArgs.
* src/Core/Banshee.Base/Library.cs: Changed definition of
LibraryTrackRemovedArgs and methodes handling/creating these.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]