banshee r3745 - in trunk/banshee: . src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView src/Libraries/Hyena.Gui/Hyena.Widgets

[scottp svn gnome org]

Author: scottp
Date: Thu Apr 10 06:03:47 2008
New Revision: 3745
URL: http://svn.gnome.org/viewvc/banshee?rev=3745&view=rev

Log:
* src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Interaction.cs:
Better vadjustment handling. This fixes BGO #526689.

* src/Libraries/Hyena.Gui/Hyena.Widgets/MenuButton.cs: Minor, perhaps
unessiary, changes.

* src/Libraries/Hyena.Gui/Hyena.Widgets/AnimatedWidget.cs: Use a bool
instead of a nullable type.

Modified:
   trunk/banshee/ChangeLog
   trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Interaction.cs
   trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/AnimatedWidget.cs
   trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/MenuButton.cs

Modified: trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Interaction.cs
==============================================================================
--- trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Interaction.cs	(original)
+++ trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Interaction.cs	Thu Apr 10 06:03:47 2008
@@ -538,6 +538,9 @@
             if (vadjustment != null && model != null) {
                 vadjustment.Upper = (RowHeight * (model.Count));
                 vadjustment.StepIncrement = RowHeight;
+                if (vadjustment.Value + vadjustment.PageSize > vadjustment.Upper) {
+                    vadjustment.Value = vadjustment.Upper - vadjustment.PageSize;
+                }
             }
             
             hadjustment.Change ();

Modified: trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/AnimatedWidget.cs
==============================================================================
--- trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/AnimatedWidget.cs	(original)
+++ trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/AnimatedWidget.cs	Thu Apr 10 06:03:47 2008
@@ -58,7 +58,8 @@
         
         private double percent;
         private int size;
-        private int? value;
+        private int value;
+        private bool has_value;
         private Pixmap canvas;
         
         public AnimatedWidget (Widget widget, uint duration, Easing easing, Blocking blocking)
@@ -172,7 +173,7 @@
             get { return size; }
             set {
                 size = value;
-                this.value = null;
+                has_value = false;
             }
         }
         
@@ -180,16 +181,16 @@
             get { return percent; }
             set {
                 percent = value * Bias;
-                this.value = null;
+                has_value = false;
             }
         }
         
         public int Value {
             get {
-                if (this.value == null) {
+                if (!has_value) {
                     this.value = Choreographer.Compose (percent, size, Easing);
                 }
-                return this.value.Value;
+                return this.value;
             }
         }
         

Modified: trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/MenuButton.cs
==============================================================================
--- trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/MenuButton.cs	(original)
+++ trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/MenuButton.cs	Thu Apr 10 06:03:47 2008
@@ -88,6 +88,8 @@
         protected override void OnUnrealized ()
         {
             WidgetFlags &= ~(WidgetFlags.Realized | WidgetFlags.NoWindow);
+            GdkWindow = null;
+            Style = null;
         }
         
         protected override void OnSizeRequested (ref Requisition requisition)