gnomemm r1664 - in gstreamermm/trunk: . gstreamer/src

[murrayc svn gnome org]

Author: murrayc
Date: Thu Aug  7 09:42:56 2008
New Revision: 1664
URL: http://svn.gnome.org/viewvc/gnomemm?rev=1664&view=rev

Log:
2008-08-07  Murray Cumming  <murrayc murrayc com>

* gstreamer/src/buffer.hg: Do not wrap gst_buffer_join() because it 
is just a C convenience function doing nasty unreffing. 
gst_buffer_merge() does the same thing without the unrefs.
As discovered in bug #533856.

Modified:
   gstreamermm/trunk/ChangeLog
   gstreamermm/trunk/gstreamer/src/buffer.hg

Modified: gstreamermm/trunk/gstreamer/src/buffer.hg
==============================================================================
--- gstreamermm/trunk/gstreamer/src/buffer.hg	(original)
+++ gstreamermm/trunk/gstreamer/src/buffer.hg	Thu Aug  7 09:42:56 2008
@@ -80,13 +80,9 @@
   //This is const because it always returns a new buffer:
   _WRAP_METHOD(Glib::RefPtr<Buffer> span(const guint32& offset, const Glib::RefPtr<Buffer>& other_buffer, const guint32& len) const, gst_buffer_span)
 
-  //Hand-code this because the C function unrefs the input parameters? Can it be const?
-  //I asked in http://bugzilla.gnome.org/show_bug.cgi?id=533856
-  //Glib::RefPtr<Buffer> join(const Glib::RefPtr<Buffer>& other_buffer);
-  //_IGNORE(gst_buffer_join)
-
-  //This is const because it always returns a new buffer:
-  _WRAP_METHOD(Glib::RefPtr<Buffer> join(const Glib::RefPtr<Buffer>& other_buffer) const, gst_buffer_join)
+  //We ignore gst_buffer_join() because it is just a C convenience function.
+  //It is gst_buffer_merge() with unrefs.
+  _IGNORE(gst_buffer_join)
 
   //This is const because it always returns a new buffer:
   _WRAP_METHOD(Glib::RefPtr<Buffer> merge(const Glib::RefPtr<const Buffer>& other_buffer) const, gst_buffer_merge)