gimp r26523 - in trunk: . app/widgets

[neo svn gnome org]

Author: neo
Date: Tue Aug 12 19:37:09 2008
New Revision: 26523
URL: http://svn.gnome.org/viewvc/gimp?rev=26523&view=rev

Log:
2008-08-12  Sven Neumann  <sven gimp org>

	* app/widgets/gimphistogrameditor.c
	(gimp_histogram_editor_frozen_update): don't do the background
	histogram unless the histogram view is actually visible.



Modified:
   trunk/ChangeLog
   trunk/app/widgets/gimphistogrameditor.c

Modified: trunk/app/widgets/gimphistogrameditor.c
==============================================================================
--- trunk/app/widgets/gimphistogrameditor.c	(original)
+++ trunk/app/widgets/gimphistogrameditor.c	Tue Aug 12 19:37:09 2008
@@ -391,7 +391,13 @@
 
   if (gimp_viewable_preview_is_frozen (GIMP_VIEWABLE (editor->drawable)))
     {
-      if (! editor->bg_histogram)
+      /* Only do the background histogram if the histogram is visible.
+       * This is a workaround for the fact that recalculating the
+       * histogram is expensive and that it is only validated when it
+       * is shown. So don't slow down painting by doing something that
+       * is not even seen by the user.
+       */
+      if (! editor->bg_histogram && GTK_WIDGET_DRAWABLE (editor))
         {
           if (gimp_histogram_editor_validate (editor))
             editor->bg_histogram = gimp_histogram_duplicate (editor->histogram);