glom r1407 - in trunk: . glom/layout_item_dialogs glom/libglom/data_structure/layout/report_parts

[murrayc svn gnome org]

Author: murrayc
Date: Sun Feb  3 01:55:59 2008
New Revision: 1407
URL: http://svn.gnome.org/viewvc/glom?rev=1407&view=rev

Log:
2008-02-03  Murray Cumming  <murrayc murrayc com>

* glom/layout_item_dialogs/dialog_field_summary.cc: on_button_field():
Pass the correct parameter to avoid a use of an uninitialized value.
* glom/libglom/data_structure/layout/report_parts/layoutitem_fields_summary.cc:
Constructor: Initialize a member variable to avoid a use of an 
uninitialized value.
This fixed the crashes in bug #513927 (GÃran)

Modified:
   trunk/ChangeLog
   trunk/glom/layout_item_dialogs/dialog_field_summary.cc
   trunk/glom/libglom/data_structure/layout/report_parts/layoutitem_fieldsummary.cc

Modified: trunk/glom/layout_item_dialogs/dialog_field_summary.cc
==============================================================================
--- trunk/glom/layout_item_dialogs/dialog_field_summary.cc	(original)
+++ trunk/glom/layout_item_dialogs/dialog_field_summary.cc	Sun Feb  3 01:55:59 2008
@@ -65,7 +65,7 @@
 
 void Dialog_FieldSummary::on_button_field()
 {
-  sharedptr<LayoutItem_Field> field = offer_field_list(field, m_table_name, this);
+  sharedptr<LayoutItem_Field> field = offer_field_list(m_layout_item, m_table_name, this);
   if(field)
   {
     m_layout_item->set_field(field);

Modified: trunk/glom/libglom/data_structure/layout/report_parts/layoutitem_fieldsummary.cc
==============================================================================
--- trunk/glom/libglom/data_structure/layout/report_parts/layoutitem_fieldsummary.cc	(original)
+++ trunk/glom/libglom/data_structure/layout/report_parts/layoutitem_fieldsummary.cc	Sun Feb  3 01:55:59 2008
@@ -25,6 +25,7 @@
 {
 
 LayoutItem_FieldSummary::LayoutItem_FieldSummary()
+: m_summary_type(TYPE_INVALID)
 {
 }