evince r3049 - in trunk: . libdocument shell

[cosimoc svn gnome org]

Author: cosimoc
Date: Tue Jun 10 18:10:50 2008
New Revision: 3049
URL: http://svn.gnome.org/viewvc/evince?rev=3049&view=rev

Log:
2008-06-10  Cosimo Cecchi  <cosimoc gnome org>

	* libdocument/ev-backends-manager.c: (ev_backends_manager_load):
	* libdocument/ev-image.c: (ev_image_save_tmp):
	* libdocument/ev-module.c: (ev_module_load):
	* shell/ev-application.c: (ev_application_shutdown),
	(ev_application_get_print_settings):
	* shell/ev-sidebar-attachments.c:
	(ev_sidebar_attachments_button_press),
	(ev_sidebar_attachments_drag_data_get):
	* shell/ev-window.c: (window_save_file_copy_ready_cb),
	(ev_window_print_finished), (ev_window_print_send),
	(ev_window_print_job_cb), (ev_window_cmd_help_contents),
	(ev_window_preview_print_finished), (ev_window_do_preview_print),
	(ev_window_cmd_preview_print):
	* shell/main.c: (load_files_remote):
	Fix some build warnings under GCC 4.3.0. (#537535).


Modified:
   trunk/ChangeLog
   trunk/libdocument/ev-backends-manager.c
   trunk/libdocument/ev-image.c
   trunk/libdocument/ev-module.c
   trunk/shell/ev-application.c
   trunk/shell/ev-sidebar-attachments.c
   trunk/shell/ev-window.c
   trunk/shell/main.c

Modified: trunk/libdocument/ev-backends-manager.c
==============================================================================
--- trunk/libdocument/ev-backends-manager.c	(original)
+++ trunk/libdocument/ev-backends-manager.c	Tue Jun 10 18:10:50 2008
@@ -118,7 +118,7 @@
 
 	dir = g_dir_open (EV_BACKENDSDIR, 0, &error);
 	if (!dir) {
-		g_warning (error->message);
+		g_warning ("%s", error->message);
 		g_error_free (error);
 
 		return FALSE;

Modified: trunk/libdocument/ev-image.c
==============================================================================
--- trunk/libdocument/ev-image.c	(original)
+++ trunk/libdocument/ev-image.c	Tue Jun 10 18:10:50 2008
@@ -152,7 +152,7 @@
 	}
 
 	/* Erro saving image */
-	g_warning (error->message);
+	g_warning ("%s", error->message);
 	g_error_free (error);
 	g_free (filename);
 

Modified: trunk/libdocument/ev-module.c
==============================================================================
--- trunk/libdocument/ev-module.c	(original)
+++ trunk/libdocument/ev-module.c	Tue Jun 10 18:10:50 2008
@@ -76,7 +76,7 @@
         module->library = g_module_open (module->path, 0);
 
         if (!module->library) {
-                g_warning (g_module_error ());
+                g_warning ("%s", g_module_error ());
 
                 return FALSE;
         }
@@ -84,7 +84,7 @@
         /* extract symbols from the lib */
         if (!g_module_symbol (module->library, "register_evince_backend",
                               (void *) &register_func)) {
-                g_warning (g_module_error ());
+                g_warning ("%s", g_module_error ());
                 g_module_close (module->library);
 
                 return FALSE;

Modified: trunk/shell/ev-application.c
==============================================================================
--- trunk/shell/ev-application.c	(original)
+++ trunk/shell/ev-application.c	Tue Jun 10 18:10:50 2008
@@ -645,7 +645,7 @@
 						    application->print_settings_file,
 						    &error);
 			if (error) {
-				g_warning (error->message);
+				g_warning ("%s", error->message);
 				g_error_free (error);
 			}
 
@@ -803,7 +803,7 @@
 			gtk_print_settings_new_from_file (application->print_settings_file, &error);
 		
 		if (error) {
-			g_warning (error->message);
+			g_warning ("%s", error->message);
 			g_error_free (error);
 		} else {
 			return application->print_settings;

Modified: trunk/shell/ev-sidebar-attachments.c
==============================================================================
--- trunk/shell/ev-sidebar-attachments.c	(original)
+++ trunk/shell/ev-sidebar-attachments.c	Tue Jun 10 18:10:50 2008
@@ -295,7 +295,7 @@
 				ev_attachment_open (attachment, &error);
 				
 				if (error) {
-					g_warning (error->message);
+					g_warning ("%s", error->message);
 					g_error_free (error);
 				}
 				
@@ -434,7 +434,7 @@
 		}
 	
 		if (error) {
-			g_warning (error->message);
+			g_warning ("%s", error->message);
 			g_error_free (error);
 		}
 

Modified: trunk/shell/ev-window.c
==============================================================================
--- trunk/shell/ev-window.c	(original)
+++ trunk/shell/ev-window.c	Tue Jun 10 18:10:50 2008
@@ -1941,7 +1941,7 @@
 					 _("The file could not be saved as â%sâ."),
 					 name);
 	gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),
-						  error->message);
+						  "%s", error->message);
 	g_signal_connect (dialog, "response",
 			  G_CALLBACK (gtk_widget_destroy),
 			  NULL);
@@ -2156,7 +2156,7 @@
 						 GTK_BUTTONS_OK,
 						 _("Failed to print document"));
 		gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),
-							  error->message);
+							  "%s", error->message);
 
 		gtk_dialog_run (GTK_DIALOG (dialog));
 		gtk_widget_destroy (dialog);
@@ -2243,7 +2243,7 @@
 					    window, NULL);
 		} else {
 			ev_window_clear_print_job (window);
-			g_warning (error->message);
+			g_warning ("%s", error->message);
 			g_error_free (error);
 		}
 	}
@@ -2256,7 +2256,7 @@
 			EvWindow   *window)
 {
 	if (job->error) {
-		g_warning (job->error->message);
+		g_warning ("%s", job->error->message);
 		ev_window_clear_print_job (window);
 		return;
 	}
@@ -3250,7 +3250,7 @@
 	screen = gtk_widget_get_screen (GTK_WIDGET (ev_window));
 	gdk_spawn_command_line_on_screen (screen, command, &error);
 	if (error != NULL) {
-		g_warning (error->message);
+		g_warning ("%s", error->message);
 		g_error_free (error);
 	}
 	g_free (command);
@@ -3306,7 +3306,7 @@
 						 GTK_BUTTONS_OK,
 						 _("Failed to print document"));
 		gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),
-							  error->message);
+							  "%s", error->message);
 
 		gtk_dialog_run (GTK_DIALOG (dialog));
 		gtk_widget_destroy (dialog);
@@ -3350,7 +3350,7 @@
 				    (GtkPrintJobCompleteFunc)ev_window_preview_print_finished,
 				    window, NULL);
 	} else {
-		g_warning (error->message);
+		g_warning ("%s", error->message);
 		g_error_free (error);
 	}
 
@@ -3375,7 +3375,7 @@
 									   &error);
 			
 			if (error) {
-				g_warning (error->message);
+				g_warning ("%s", error->message);
 				g_error_free (error);
 				print_settings = NULL;
 			}

Modified: trunk/shell/main.c
==============================================================================
--- trunk/shell/main.c	(original)
+++ trunk/shell/main.c	Tue Jun 10 18:10:50 2008
@@ -252,7 +252,7 @@
 	connection = dbus_g_bus_get (DBUS_BUS_STARTER, &error);
 
 	if (connection == NULL) {
-		g_warning (error->message);
+		g_warning ("%s", error->message);
 		g_error_free (error);	
 
 		return FALSE;
@@ -268,7 +268,7 @@
 					G_TYPE_UINT, timestamp,
 					G_TYPE_INVALID,
 					G_TYPE_INVALID)) {
-			g_warning (error->message);
+			g_warning ("%s", error->message);
 			g_clear_error (&error);
 			g_object_unref (remote_object);
 			dbus_g_connection_unref (connection);
@@ -298,7 +298,7 @@
 					G_TYPE_UINT, timestamp,
 					G_TYPE_INVALID,
 					G_TYPE_INVALID)) {
-			g_warning (error->message);
+			g_warning ("%s", error->message);
 			g_clear_error (&error);
 			g_free (uri);
 			continue;