banshee r3384 - in trunk/banshee: . build src/Core/Banshee.Core/Banshee.Streaming src/Core/Banshee.ThickClient/Banshee.Gui src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue src/Libraries/Hyena.Gui/Hyena.Data.Gui src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView
- From: abock svn gnome org
- To: svn-commits-list gnome org
- Subject: banshee r3384 - in trunk/banshee: . build src/Core/Banshee.Core/Banshee.Streaming src/Core/Banshee.ThickClient/Banshee.Gui src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue src/Libraries/Hyena.Gui/Hyena.Data.Gui src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView
- Date: Wed, 5 Mar 2008 17:27:26 +0000 (GMT)
Author: abock
Date: Wed Mar 5 17:27:25 2008
New Revision: 3384
URL: http://svn.gnome.org/viewvc/banshee?rev=3384&view=rev
Log:
2008-03-05 Aaron Bockover <abock gnome org>
* build/build.rules.mk: Turned on -warnaserror and only show the bold
compiling message if the terminal supports colors and is a tty
* src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs:
* src/Core/Banshee.ThickClient/Banshee.Gui/PlaybackRepeatActions.cs:
* src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue/PlayQueueSource.cs:
* src/Libraries/Hyena.Gui/Hyena.Data.Gui/CairoHelper.cs:
* src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Model.cs:
Fixed warnings
Modified:
trunk/banshee/ChangeLog
trunk/banshee/build/build.rules.mk
trunk/banshee/src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs
trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/PlaybackRepeatActions.cs
trunk/banshee/src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue/PlayQueueSource.cs
trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Data.Gui/CairoHelper.cs
trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Model.cs
Modified: trunk/banshee/build/build.rules.mk
==============================================================================
--- trunk/banshee/build/build.rules.mk (original)
+++ trunk/banshee/build/build.rules.mk Wed Mar 5 17:27:25 2008
@@ -21,8 +21,19 @@
$(ASSEMBLY_FILE): $(SOURCES_BUILD) $(RESOURCES_EXPANDED)
@mkdir -p $(top_builddir)/bin
- @echo -e "\033[1mCompiling $(notdir $@)...\033[0m"
- @$(BUILD) -target:$(TARGET) -out:$@ $(LINK) $(RESOURCES_BUILD) $(SOURCES_BUILD)
+ @colors=no; \
+ case $$TERM in \
+ "xterm" | "rxvt" | "rxvt-unicode") \
+ test "x$$COLORTERM" != "x" && colors=yes ;; \
+ "xterm-color") colors=yes ;; \
+ esac; \
+ if [ "x$$colors" = "xyes" ]; then \
+ tty -s && true || { colors=no; true; } \
+ fi; \
+ test "x$$colors" = "xyes" && \
+ echo -e "\033[1mCompiling $(notdir $@)...\033[0m" || \
+ echo "Compiling $(notdir $@)...";
+ @$(BUILD) -target:$(TARGET) -out:$@ -warnaserror $(LINK) $(RESOURCES_BUILD) $(SOURCES_BUILD)
@if [ -e $(notdir $ config) ]; then \
cp $(notdir $ config) $(top_builddir)/bin; \
fi;
Modified: trunk/banshee/src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs
==============================================================================
--- trunk/banshee/src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs (original)
+++ trunk/banshee/src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs Wed Mar 5 17:27:25 2008
@@ -60,11 +60,15 @@
: String.IsNullOrEmpty (priority) ? fallback : priority;
}
+ #pragma warning disable 0169
+
private static int Choose (int priority, int fallback)
{
return Choose (priority, fallback, false);
}
-
+
+ #pragma warning restore 0169
+
private static int Choose (int priority, int fallback, bool flip)
{
return flip
Modified: trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/PlaybackRepeatActions.cs
==============================================================================
--- trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/PlaybackRepeatActions.cs (original)
+++ trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/PlaybackRepeatActions.cs Wed Mar 5 17:27:25 2008
@@ -39,7 +39,6 @@
{
public class PlaybackRepeatActions : BansheeActionGroup, IEnumerable<RadioAction>
{
- private InterfaceActionService action_service;
private RadioAction active_action;
public RadioAction Active {
@@ -70,8 +69,6 @@
Catalog.GetString ("Repeat the current playing song"), 2)
}, 0, OnChanged);
- action_service = actionService;
-
Gtk.Action action = this[ConfigIdToActionName (RepeatMode.Get ())];
if (action is RadioAction) {
active_action = (RadioAction)action;
Modified: trunk/banshee/src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue/PlayQueueSource.cs
==============================================================================
--- trunk/banshee/src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue/PlayQueueSource.cs (original)
+++ trunk/banshee/src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue/PlayQueueSource.cs Wed Mar 5 17:27:25 2008
@@ -52,7 +52,6 @@
private static string special_playlist_name = typeof (PlayQueueSource).ToString ();
private DatabaseTrackInfo playing_track;
- private BansheeActionGroup actions;
private bool actions_loaded = false;
public PlayQueueSource () : base (Catalog.GetString ("Play Queue"), null)
@@ -78,7 +77,6 @@
OnAddToPlayQueue)
});
- actions = new BansheeActionGroup ("PlayQueueSource");
uia_service.GlobalActions.AddImportant (
new ActionEntry ("ClearPlayQueueAction", Stock.Clear,
Catalog.GetString ("Clear"), null,
Modified: trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Data.Gui/CairoHelper.cs
==============================================================================
--- trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Data.Gui/CairoHelper.cs (original)
+++ trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Data.Gui/CairoHelper.cs Wed Mar 5 17:27:25 2008
@@ -34,8 +34,8 @@
{
public static class CairoHelper
{
- [System.Runtime.InteropServices.DllImport ("libgdk-x11-2.0.so")]
- private static extern IntPtr gdk_cairo_create (IntPtr raw);
+ // [System.Runtime.InteropServices.DllImport ("libgdk-x11-2.0.so")]
+ // private static extern IntPtr gdk_cairo_create (IntPtr raw);
public static Cairo.Context CreateCairoDrawable (Gdk.Drawable drawable)
{
Modified: trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Model.cs
==============================================================================
--- trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Model.cs (original)
+++ trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Model.cs Wed Mar 5 17:27:25 2008
@@ -148,9 +148,13 @@
return (bool)row_sensitive_property_info.GetValue (item, null);
}
+ #pragma warning disable 0169
+
private bool IsRowSensitive (int index)
{
return IsRowSensitive (model[index]);
}
+
+ #pragma warning restore 0169
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]