gnumeric r16564 - in trunk: . plugins/fn-lookup

[mortenw svn gnome org]

Author: mortenw
Date: Fri May 16 20:10:04 2008
New Revision: 16564
URL: http://svn.gnome.org/viewvc/gnumeric?rev=16564&view=rev

Log:
2008-05-16  Morten Welinder  <terra gnome org>

	* functions.c (gnumeric_areas): Check the value type of the
	calculation function result, not something weird with the call
	itself.  Fixes #533370.



Modified:
   trunk/NEWS
   trunk/plugins/fn-lookup/ChangeLog
   trunk/plugins/fn-lookup/functions.c

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS	(original)
+++ trunk/NEWS	Fri May 16 20:10:04 2008
@@ -4,6 +4,7 @@
 	* Fix Excel export problem for strings that need quoting.  [#530704]
 	* Internal cleanup for analysis tools.  [#532210]
 	* Fix hang.  [#533288]
+	* Fix AREAS crash.  [#533370]
 
 --------------------------------------------------------------------------
 Gnumeric 1.9.0

Modified: trunk/plugins/fn-lookup/functions.c
==============================================================================
--- trunk/plugins/fn-lookup/functions.c	(original)
+++ trunk/plugins/fn-lookup/functions.c	Fri May 16 20:10:04 2008
@@ -629,7 +629,7 @@
 	case GNM_EXPR_OP_FUNCALL: {
 		GnmValue *v = gnm_expr_eval (expr, ei->pos,
 			GNM_EXPR_EVAL_PERMIT_NON_SCALAR);
-		if (expr->constant.value->type == VALUE_CELLRANGE)
+		if (v->type == VALUE_CELLRANGE)
 			res = 1;
 		value_release (v);
 		break;