libgnomeui r5607 - in trunk: . file-chooser

[carlosg svn gnome org]

Author: carlosg
Date: Tue May 27 23:33:44 2008
New Revision: 5607
URL: http://svn.gnome.org/viewvc/libgnomeui?rev=5607&view=rev

Log:
2008-05-28  Carlos Garnacho  <carlos imendio com>

        * file-chooser/gtkfilesystemgio.c: Improve bookmarks handling by not
        returning a reversed list in read_bookmarks_file(), which makes things
        more straighforward. Fixes #530978.



Modified:
   trunk/ChangeLog
   trunk/file-chooser/gtkfilesystemgio.c

Modified: trunk/file-chooser/gtkfilesystemgio.c
==============================================================================
--- trunk/file-chooser/gtkfilesystemgio.c	(original)
+++ trunk/file-chooser/gtkfilesystemgio.c	Tue May 27 23:33:44 2008
@@ -1595,7 +1595,7 @@
   g_free (contents);
   g_object_unref (file);
 
-  return bookmarks;
+  return g_list_reverse (bookmarks);
 }
 
 static void
@@ -1607,12 +1607,6 @@
   GList *elem;
   GFile *file;
 
-  /* read_bookmarks_file returns the list reversed
-   * in order to just prepend elements in list_bookmarks,
-   * so to keep the same order we have to reverse it here
-   */
-  bookmarks = g_list_reverse (bookmarks);
-
   filename = get_bookmarks_filename ();
   file = g_file_new_for_path (filename);
   g_free (filename);
@@ -1764,6 +1758,7 @@
 
   DEBUG ("list_bookmarks");
   bookmarks = read_bookmarks_file ();
+  bookmarks = g_list_reverse (bookmarks);
 
   for (elem = bookmarks; elem; elem = elem->next)
     {