GNOME.org
 

[eog] Unexport functions that are only used internally

commit 25c84ff0eb0b317aa64935ddb31879ca1359716e
Author: Felix Riemann <friemann svn gnome org>
Date:   Fri Apr 24 21:16:55 2009 +0200

    Unexport functions that are only used internally
    
    Stops functions from being exported that are not meant to be used by
    plugin developers. This could help optimizing function calls also.
---
 ChangeLog                       |   26 ++++++++++++++++++++++++++
 src/eog-image-jpeg.h            |    1 +
 src/eog-metadata-reader-jpg.h   |    1 +
 src/eog-metadata-reader-png.h   |    1 +
 src/eog-metadata-reader.h       |   10 ++++++++++
 src/eog-module.h                |    4 ++++
 src/eog-pixbuf-cell-renderer.h  |    2 ++
 src/eog-pixbuf-util.h           |    4 ++++
 src/eog-plugin-engine.h         |   17 +++++++++++++++++
 src/eog-plugin-manager.h        |    2 ++
 src/eog-preferences-dialog.h    |    2 ++
 src/eog-print-image-setup.h     |    3 +++
 src/eog-print-preview.h         |    8 ++++++++
 src/eog-print.h                 |    8 ++++++++
 src/eog-python-module.h         |    7 ++++++-
 src/eog-python-plugin.h         |    1 +
 src/eog-save-as-dialog-helper.h |    3 ++-
 src/eog-session.h               |    3 +++
 src/eog-uri-converter.h         |    9 +++++++++
 src/eog-util.h                  |   10 ++++++++++
 src/uta.h                       |   10 ++++++++++
 src/zoom.h                      |    3 ++-
 22 files changed, 132 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 280eb60..d9acf3f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,29 @@
+2009-04-24  Felix Riemann  <friemann svn gnome org>
+
+        * src/eog-image-jpeg.h:
+        * src/eog-metadata-reader-jpg.h:
+        * src/eog-metadata-reader-png.h:
+        * src/eog-metadata-reader.h:
+        * src/eog-module.h:
+        * src/eog-pixbuf-cell-renderer.h:
+        * src/eog-pixbuf-util.h:
+        * src/eog-plugin-engine.h:
+        * src/eog-plugin-manager.h:
+        * src/eog-preferences-dialog.h:
+        * src/eog-print-image-setup.h:
+        * src/eog-print-preview.h:
+        * src/eog-print.h:
+        * src/eog-python-module.h:
+        * src/eog-python-plugin.h:
+        * src/eog-save-as-dialog-helper.h:
+        * src/eog-session.h:
+        * src/eog-uri-converter.h:
+        * src/eog-util.h:
+        * src/uta.h:
+        * src/zoom.h:
+
+	Don't export functions whose headers are not installed for plugins.
+
 2009-04-23  Claudio Saavedra  <csaavedra igalia com>
 
 	* src/eog-thumb-nav.c: (eog_thumb_nav_set_mode): Do not set
diff --git a/src/eog-image-jpeg.h b/src/eog-image-jpeg.h
index aa4e035..9dd26c1 100644
--- a/src/eog-image-jpeg.h
+++ b/src/eog-image-jpeg.h
@@ -13,6 +13,7 @@
  * possible. It will save the image as lossless as possible (if the
  * target is a jpeg image too).
  */
+G_GNUC_INTERNAL
 gboolean eog_image_jpeg_save_file (EogImage *image, const char *file,
 				   EogImageSaveInfo *source, EogImageSaveInfo *target,
 				   GError **error);
diff --git a/src/eog-metadata-reader-jpg.h b/src/eog-metadata-reader-jpg.h
index 4bb093f..e772569 100644
--- a/src/eog-metadata-reader-jpg.h
+++ b/src/eog-metadata-reader-jpg.h
@@ -47,6 +47,7 @@ struct _EogMetadataReaderJpgClass {
 	GObjectClass parent_klass;
 };
 
+G_GNUC_INTERNAL
 GType		      eog_metadata_reader_jpg_get_type	(void) G_GNUC_CONST;
 
 G_END_DECLS
diff --git a/src/eog-metadata-reader-png.h b/src/eog-metadata-reader-png.h
index d36d87e..da41b40 100644
--- a/src/eog-metadata-reader-png.h
+++ b/src/eog-metadata-reader-png.h
@@ -47,6 +47,7 @@ struct _EogMetadataReaderPngClass {
 	GObjectClass parent_klass;
 };
 
+G_GNUC_INTERNAL
 GType		      eog_metadata_reader_png_get_type	(void) G_GNUC_CONST;
 
 G_END_DECLS
diff --git a/src/eog-metadata-reader.h b/src/eog-metadata-reader.h
index c76931a..4f49fc9 100644
--- a/src/eog-metadata-reader.h
+++ b/src/eog-metadata-reader.h
@@ -68,23 +68,32 @@ typedef enum {
 	EOG_METADATA_PNG
 } EogMetadataFileType;
 
+G_GNUC_INTERNAL
 GType                eog_metadata_reader_get_type	(void) G_GNUC_CONST;
 
+G_GNUC_INTERNAL
 EogMetadataReader*   eog_metadata_reader_new 		(EogMetadataFileType type);
+
+G_GNUC_INTERNAL
 void                 eog_metadata_reader_consume	(EogMetadataReader *emr,
 							 const guchar *buf,
 							 guint len);
+
+G_GNUC_INTERNAL
 gboolean             eog_metadata_reader_finished	(EogMetadataReader *emr);
 
+G_GNUC_INTERNAL
 void                 eog_metadata_reader_get_exif_chunk (EogMetadataReader *emr,
 							 guchar **data,
 							 guint *len);
 
 #ifdef HAVE_EXIF
+G_GNUC_INTERNAL
 ExifData*            eog_metadata_reader_get_exif_data	(EogMetadataReader *emr);
 #endif
 
 #ifdef HAVE_EXEMPI
+G_GNUC_INTERNAL
 XmpPtr	     	     eog_metadata_reader_get_xmp_data	(EogMetadataReader *emr);
 #endif
 
@@ -94,6 +103,7 @@ IptcData*            eog_metadata_reader_get_iptc_data	(EogMetadataReader *emr);
 #endif
 
 #ifdef HAVE_LCMS
+G_GNUC_INTERNAL
 cmsHPROFILE          eog_metadata_reader_get_icc_profile (EogMetadataReader *emr);
 #endif
 
diff --git a/src/eog-module.h b/src/eog-module.h
index 8cc9566..1d44813 100644
--- a/src/eog-module.h
+++ b/src/eog-module.h
@@ -55,12 +55,16 @@ struct _EogModuleClass {
 	GTypeModuleClass parent_class;
 };
 
+G_GNUC_INTERNAL
 GType		 eog_module_get_type	(void) G_GNUC_CONST;
 
+G_GNUC_INTERNAL
 EogModule	*eog_module_new		(const gchar *path);
 
+G_GNUC_INTERNAL
 const gchar	*eog_module_get_path	(EogModule *module);
 
+G_GNUC_INTERNAL
 GObject		*eog_module_new_object	(EogModule *module);
 
 G_END_DECLS
diff --git a/src/eog-pixbuf-cell-renderer.h b/src/eog-pixbuf-cell-renderer.h
index 1346bcb..78becbb 100644
--- a/src/eog-pixbuf-cell-renderer.h
+++ b/src/eog-pixbuf-cell-renderer.h
@@ -42,8 +42,10 @@ struct _EogPixbufCellRendererClass
 	GtkCellRendererPixbufClass parent;
 };
 
+G_GNUC_INTERNAL
 GType            eog_pixbuf_cell_renderer_get_type (void) G_GNUC_CONST;
 
+G_GNUC_INTERNAL
 GtkCellRenderer *eog_pixbuf_cell_renderer_new (void);
 
 G_END_DECLS
diff --git a/src/eog-pixbuf-util.h b/src/eog-pixbuf-util.h
index 7c4ad22..54f2820 100644
--- a/src/eog-pixbuf-util.h
+++ b/src/eog-pixbuf-util.h
@@ -4,12 +4,16 @@
 #include <gdk-pixbuf/gdk-pixbuf.h>
 #include <gio/gio.h>
 
+G_GNUC_INTERNAL
 GSList*          eog_pixbuf_get_savable_formats (void);
 
+G_GNUC_INTERNAL
 GdkPixbufFormat* eog_pixbuf_get_format_by_suffix (const char *suffix);
 
+G_GNUC_INTERNAL
 GdkPixbufFormat* eog_pixbuf_get_format (GFile *file);
 
+G_GNUC_INTERNAL
 char*            eog_pixbuf_get_common_suffix (GdkPixbufFormat *format);
 
 #endif /* _EOG_PIXBUF_UTIL_H_ */
diff --git a/src/eog-plugin-engine.h b/src/eog-plugin-engine.h
index 3472675..43f3a76 100644
--- a/src/eog-plugin-engine.h
+++ b/src/eog-plugin-engine.h
@@ -31,42 +31,59 @@
 
 typedef struct _EogPluginInfo EogPluginInfo;
 
+G_GNUC_INTERNAL
 gboolean	 eog_plugin_engine_init 		(void);
 
+G_GNUC_INTERNAL
 void		 eog_plugin_engine_shutdown 		(void);
 
+G_GNUC_INTERNAL
 void		 eog_plugin_engine_garbage_collect	(void);
 
+G_GNUC_INTERNAL
 const GList	*eog_plugin_engine_get_plugins_list 	(void);
 
+G_GNUC_INTERNAL
 gboolean 	 eog_plugin_engine_activate_plugin 	(EogPluginInfo *info);
 
+G_GNUC_INTERNAL
 gboolean 	 eog_plugin_engine_deactivate_plugin	(EogPluginInfo *info);
 
+G_GNUC_INTERNAL
 gboolean 	 eog_plugin_engine_plugin_is_active 	(EogPluginInfo *info);
 
+G_GNUC_INTERNAL
 gboolean 	 eog_plugin_engine_plugin_is_available	(EogPluginInfo *info);
 
+G_GNUC_INTERNAL
 gboolean	 eog_plugin_engine_plugin_is_configurable
 			       				(EogPluginInfo *info);
 
+G_GNUC_INTERNAL
 void	 	 eog_plugin_engine_configure_plugin	(EogPluginInfo *info,
 			       			 	 GtkWindow     *parent);
 
+G_GNUC_INTERNAL
 void		 eog_plugin_engine_update_plugins_ui	(EogWindow     *window,
 			       			 	 gboolean       new_window);
 
+G_GNUC_INTERNAL
 const gchar	*eog_plugin_engine_get_plugin_name	(EogPluginInfo *info);
 
+G_GNUC_INTERNAL
 const gchar	*eog_plugin_engine_get_plugin_description
 			       				(EogPluginInfo *info);
 
+G_GNUC_INTERNAL
 const gchar	*eog_plugin_engine_get_plugin_icon_name (EogPluginInfo *info);
 
+G_GNUC_INTERNAL
 const gchar    **eog_plugin_engine_get_plugin_authors   (EogPluginInfo *info);
 
+G_GNUC_INTERNAL
 const gchar	*eog_plugin_engine_get_plugin_website   (EogPluginInfo *info);
 
+G_GNUC_INTERNAL
 const gchar	*eog_plugin_engine_get_plugin_copyright (EogPluginInfo *info);
 
 #endif  /* __EOG_PLUGIN_ENGINE_H__ */
diff --git a/src/eog-plugin-manager.h b/src/eog-plugin-manager.h
index 56a3f61..6c34ad6 100644
--- a/src/eog-plugin-manager.h
+++ b/src/eog-plugin-manager.h
@@ -50,8 +50,10 @@ struct _EogPluginManagerClass {
 	GtkVBoxClass parent_class;
 };
 
+G_GNUC_INTERNAL
 GType		 eog_plugin_manager_get_type	(void) G_GNUC_CONST;
 
+G_GNUC_INTERNAL
 GtkWidget	*eog_plugin_manager_new		(void);
 
 G_END_DECLS
diff --git a/src/eog-preferences-dialog.h b/src/eog-preferences-dialog.h
index 819460c..c02215f 100644
--- a/src/eog-preferences-dialog.h
+++ b/src/eog-preferences-dialog.h
@@ -54,8 +54,10 @@ struct _EogPreferencesDialogClass {
 	EogDialogClass parent_class;
 };
 
+G_GNUC_INTERNAL
 GType	    eog_preferences_dialog_get_type	  (void) G_GNUC_CONST;
 
+G_GNUC_INTERNAL
 GObject    *eog_preferences_dialog_get_instance	  (GtkWindow   *parent,
 					 	   GConfClient *client);
 
diff --git a/src/eog-print-image-setup.h b/src/eog-print-image-setup.h
index 89b3a88..0a6b49e 100644
--- a/src/eog-print-image-setup.h
+++ b/src/eog-print-image-setup.h
@@ -47,11 +47,14 @@ struct _EogPrintImageSetupClass {
 	GtkTableClass parent_class;
 };
 
+G_GNUC_INTERNAL
 GType		  eog_print_image_setup_get_type    (void) G_GNUC_CONST;
 
+G_GNUC_INTERNAL
 GtkWidget        *eog_print_image_setup_new         (EogImage     *image,
 						     GtkPageSetup *page_setup);
 
+G_GNUC_INTERNAL
 void              eog_print_image_setup_get_options (EogPrintImageSetup *setup,
 						     gdouble            *left,
 						     gdouble            *top,
diff --git a/src/eog-print-preview.h b/src/eog-print-preview.h
index b976636..d145dd2 100644
--- a/src/eog-print-preview.h
+++ b/src/eog-print-preview.h
@@ -45,29 +45,37 @@ struct _EogPrintPreviewClass {
 
 };
 
+G_GNUC_INTERNAL
 GType        eog_print_preview_get_type            (void) G_GNUC_CONST;
 
+G_GNUC_INTERNAL
 GtkWidget   *eog_print_preview_new                 (void);
 
+G_GNUC_INTERNAL
 GtkWidget   *eog_print_preview_new_with_pixbuf     (GdkPixbuf       *pixbuf);
 
+G_GNUC_INTERNAL
 void         eog_print_preview_set_page_margins    (EogPrintPreview *preview,
 						    gfloat          l_margin,
 						    gfloat          r_margin,
 						    gfloat          t_margin,
 						    gfloat          b_margin);
 
+G_GNUC_INTERNAL
 void         eog_print_preview_set_from_page_setup (EogPrintPreview *preview,
 						    GtkPageSetup    *setup);
 
+G_GNUC_INTERNAL
 void         eog_print_preview_get_image_position  (EogPrintPreview *preview,
 						    gdouble         *x,
 						    gdouble         *y);
 
+G_GNUC_INTERNAL
 void         eog_print_preview_set_image_position  (EogPrintPreview *preview,
 						    gdouble          x,
 						    gdouble          y);
 
+G_GNUC_INTERNAL
 void         eog_print_preview_set_scale           (EogPrintPreview *preview,
 						    gfloat           scale);
 
diff --git a/src/eog-print.h b/src/eog-print.h
index 9dfbf65..a0fedbb 100644
--- a/src/eog-print.h
+++ b/src/eog-print.h
@@ -27,13 +27,21 @@
 
 G_BEGIN_DECLS
 
+G_GNUC_INTERNAL
 GtkPrintOperation*    eog_print_operation_new (EogImage *image,
 					       GtkPrintSettings *print_settings,
 					       GtkPageSetup *page_setup);
 
+G_GNUC_INTERNAL
 GtkPageSetup*         eog_print_get_page_setup (void);
+
+G_GNUC_INTERNAL
 void                  eog_print_set_page_setup (GtkPageSetup *page_setup);
+
+G_GNUC_INTERNAL
 GtkPrintSettings *    eog_print_get_print_settings (void);
+
+G_GNUC_INTERNAL
 void                  eog_print_set_print_settings (GtkPrintSettings *print_settings);
 
 G_END_DECLS
diff --git a/src/eog-python-module.h b/src/eog-python-module.h
index c087643..1e51fc1 100644
--- a/src/eog-python-module.h
+++ b/src/eog-python-module.h
@@ -49,18 +49,23 @@ struct _EogPythonModule {
 	GTypeModule parent_instance;
 };
 
+G_GNUC_INTERNAL
 GType			 eog_python_module_get_type		(void) G_GNUC_CONST;
 
+G_GNUC_INTERNAL
 EogPythonModule		*eog_python_module_new			(const gchar* path,
 								 const gchar *module);
 
+G_GNUC_INTERNAL
 GObject			*eog_python_module_new_object		(EogPythonModule *module);
 
-
+G_GNUC_INTERNAL
 gboolean		eog_python_init				(void);
 
+G_GNUC_INTERNAL
 void			eog_python_shutdown			(void);
 
+G_GNUC_INTERNAL
 void			eog_python_garbage_collect		(void);
 
 G_END_DECLS
diff --git a/src/eog-python-plugin.h b/src/eog-python-plugin.h
index 910f70f..ce74ff8 100644
--- a/src/eog-python-plugin.h
+++ b/src/eog-python-plugin.h
@@ -47,6 +47,7 @@ struct _EogPythonPluginClass {
 	PyObject *type;
 };
 
+G_GNUC_INTERNAL
 GType eog_python_plugin_get_type (GTypeModule *module, PyObject *type);
 
 G_END_DECLS
diff --git a/src/eog-save-as-dialog-helper.h b/src/eog-save-as-dialog-helper.h
index 3f5610e..85d0b26 100644
--- a/src/eog-save-as-dialog-helper.h
+++ b/src/eog-save-as-dialog-helper.h
@@ -8,9 +8,10 @@
 
 G_BEGIN_DECLS
 
-
+G_GNUC_INTERNAL
 GtkWidget*    eog_save_as_dialog_new       (GtkWindow *main, GList *images, GFile *base_file);
 
+G_GNUC_INTERNAL
 EogURIConverter* eog_save_as_dialog_get_converter (GtkWidget *dlg);
 
 
diff --git a/src/eog-session.h b/src/eog-session.h
index b1a3178..9e4db44 100644
--- a/src/eog-session.h
+++ b/src/eog-session.h
@@ -32,10 +32,13 @@
 
 G_BEGIN_DECLS
 
+G_GNUC_INTERNAL
 void 		eog_session_init 		(EogApplication *application);
 
+G_GNUC_INTERNAL
 gboolean 	eog_session_is_restored 	(void);
 
+G_GNUC_INTERNAL
 gboolean 	eog_session_load 		(void);
 
 G_END_DECLS
diff --git a/src/eog-uri-converter.h b/src/eog-uri-converter.h
index 4d015f3..21b5505 100644
--- a/src/eog-uri-converter.h
+++ b/src/eog-uri-converter.h
@@ -63,25 +63,33 @@ struct _EogURIConverterClass {
 	GObjectClass parent_klass;
 };
 
+G_GNUC_INTERNAL
 GType              eog_uri_converter_get_type      (void) G_GNUC_CONST;
+
+G_GNUC_INTERNAL
 GQuark             eog_uc_error_quark              (void);
 
+G_GNUC_INTERNAL
 EogURIConverter*   eog_uri_converter_new           (GFile *base_file,
                                                     GdkPixbufFormat *img_format,
 						    const char *format_string);
 
+G_GNUC_INTERNAL
 gboolean           eog_uri_converter_check         (EogURIConverter *converter,
                                                     GList *img_list,
                                                     GError **error);
 
+G_GNUC_INTERNAL
 gboolean           eog_uri_converter_requires_exif (EogURIConverter *converter);
 
+G_GNUC_INTERNAL
 gboolean           eog_uri_converter_do            (EogURIConverter *converter,
                                                     EogImage *image,
                                                     GFile **file,
                                                     GdkPixbufFormat **format,
                                                     GError **error);
 
+G_GNUC_INTERNAL
 char*              eog_uri_converter_preview       (const char *format_str,
                                                     EogImage *img,
                                                     GdkPixbufFormat *format,
@@ -91,6 +99,7 @@ char*              eog_uri_converter_preview       (const char *format_str,
 						    gunichar space_char);
 
 /* for debugging purpose only */
+G_GNUC_INTERNAL
 void                eog_uri_converter_print_list (EogURIConverter *conv);
 
 G_END_DECLS
diff --git a/src/eog-util.h b/src/eog-util.h
index c136d6e..31f95ac 100644
--- a/src/eog-util.h
+++ b/src/eog-util.h
@@ -29,29 +29,39 @@
 
 G_BEGIN_DECLS
 
+G_GNUC_INTERNAL
 void     eog_util_show_help                  (const gchar *section,
 					      GtkWindow   *parent);
 
+G_GNUC_INTERNAL
 gchar   *eog_util_make_valid_utf8            (const gchar *name);
 
+G_GNUC_INTERNAL
 GSList  *eog_util_parse_uri_string_list_to_file_list (const gchar *uri_list);
 
+G_GNUC_INTERNAL
 GSList  *eog_util_string_list_to_file_list    (GSList *string_list);
 
 #ifdef HAVE_DBUS
+G_GNUC_INTERNAL
 GSList  *eog_util_strings_to_file_list        (gchar **strings);
 #endif
 
+G_GNUC_INTERNAL
 GSList  *eog_util_string_array_to_list       (const gchar **files,
 	 				      gboolean create_uri);
 
+G_GNUC_INTERNAL
 gchar  **eog_util_string_array_make_absolute (gchar **files);
 
+G_GNUC_INTERNAL
 gboolean eog_util_launch_desktop_file        (const gchar *filename,
 					      guint32      user_time);
 
+G_GNUC_INTERNAL
 const    gchar *eog_util_dot_dir             (void);
 
+G_GNUC_INTERNAL
 char *  eog_util_filename_get_extension      (const char * filename_with_extension);
 
 G_END_DECLS
diff --git a/src/uta.h b/src/uta.h
index 153d795..ec8d1ce 100644
--- a/src/uta.h
+++ b/src/uta.h
@@ -46,18 +46,28 @@ typedef struct _EogUta EogUta;
 
 
 
+G_GNUC_INTERNAL
 void	eog_uta_free 		(EogUta *uta);
+
+G_GNUC_INTERNAL
 void	eog_irect_intersect 	(EogIRect *dest,
 				 const EogIRect *src1, const EogIRect *src2);
+G_GNUC_INTERNAL
 int	eog_irect_empty 	(const EogIRect *src);
 
+G_GNUC_INTERNAL
 EogUta *uta_ensure_size (EogUta *uta, int x1, int y1, int x2, int y2);
 
+G_GNUC_INTERNAL
 EogUta *uta_add_rect (EogUta *uta, int x1, int y1, int x2, int y2);
+
+G_GNUC_INTERNAL
 void uta_remove_rect (EogUta *uta, int x1, int y1, int x2, int y2);
 
+G_GNUC_INTERNAL
 void uta_find_first_glom_rect (EogUta *uta, EogIRect *rect, int max_width, int max_height);
 
+G_GNUC_INTERNAL
 void uta_copy_area (EogUta *uta, int src_x, int src_y, int dest_x, int dest_y, int width, int height);
 
 
diff --git a/src/zoom.h b/src/zoom.h
index d145af4..22ace00 100644
--- a/src/zoom.h
+++ b/src/zoom.h
@@ -24,12 +24,13 @@
 
 #include <glib.h>
 
-
+G_GNUC_INTERNAL
 void zoom_fit_size (guint dest_width, guint dest_height,
 		    guint src_width, guint src_height,
 		    gboolean upscale_smaller,
 		    guint *width, guint *height);
 
+G_GNUC_INTERNAL
 double zoom_fit_scale (guint dest_width, guint dest_height,
 		       guint src_width, guint src_height,
 		       gboolean upscale_smaller);
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]