[epiphany] ephy-embed.c: add FIXME



commit d1ae115956d42347107dc0d4dbe682281b648915
Author: Xan Lopez <xan gnome org>
Date:   Mon Aug 10 23:46:12 2009 +0300

    ephy-embed.c: add FIXME

 embed/ephy-embed.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
---
diff --git a/embed/ephy-embed.c b/embed/ephy-embed.c
index 5591c94..f9f9c53 100644
--- a/embed/ephy-embed.c
+++ b/embed/ephy-embed.c
@@ -200,6 +200,11 @@ load_status_changed_cb (WebKitWebView *view,
     ephy_web_view_set_security_level (EPHY_WEB_VIEW (view), security_level);
   } else {
     EphyWebViewNetState estate = EPHY_WEB_VIEW_STATE_UNKNOWN;
+    /* FIXME: this does not work for URLs opened without typing
+       (middle click, etc). We should use get_address, but WebKit does
+       not update its URI property until LOAD_COMMITTED, so we'll get
+       NULL here. We need to either change WebKit or fetch the address
+       we are trying to load from our side. */
     const char *loading_uri = ephy_web_view_get_typed_address (EPHY_WEB_VIEW (view));
 
     if (status == WEBKIT_LOAD_PROVISIONAL) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]