[empathy] tp_contact_list_remove: add FIXME about potential race



commit db0b0f0ad369618f8204bbdf918aa574ccb25c8c
Author: Guillaume Desmottes <guillaume desmottes collabora co uk>
Date:   Wed Dec 9 16:15:09 2009 +0000

    tp_contact_list_remove: add FIXME about potential race

 libempathy/empathy-tp-contact-list.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/libempathy/empathy-tp-contact-list.c b/libempathy/empathy-tp-contact-list.c
index 9ef71b4..9b67ec7 100644
--- a/libempathy/empathy-tp-contact-list.c
+++ b/libempathy/empathy-tp-contact-list.c
@@ -1060,6 +1060,8 @@ tp_contact_list_remove (EmpathyContactList *list,
 
 	handle = empathy_contact_get_handle (contact);
 
+	/* FIXME: this is racy if tp_contact_list_remove is called before the
+	 * 'stored' list has been retrieved. */
 	if (priv->stored != NULL) {
 		tp_cli_channel_interface_group_call_remove_members (priv->stored,
 			-1, &handles, message, NULL, NULL, NULL, NULL);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]