orca r4534 - in trunk: . src/orca/scripts/toolkits/Gecko test/keystrokes/firefox

[wwalker svn gnome org]

Author: wwalker
Date: Fri Feb 13 00:51:45 2009
New Revision: 4534
URL: http://svn.gnome.org/viewvc/orca?rev=4534&view=rev

Log:
Fix for bug #570551 - (ARIA) UIUC Number Guessing Game Alert Dialog not presented when it appears


Added:
   trunk/test/keystrokes/firefox/uiuc_alert.py
Modified:
   trunk/ChangeLog
   trunk/src/orca/scripts/toolkits/Gecko/script.py
   trunk/src/orca/scripts/toolkits/Gecko/speech_generator.py

Modified: trunk/src/orca/scripts/toolkits/Gecko/script.py
==============================================================================
--- trunk/src/orca/scripts/toolkits/Gecko/script.py	(original)
+++ trunk/src/orca/scripts/toolkits/Gecko/script.py	Fri Feb 13 00:51:45 2009
@@ -1688,7 +1688,18 @@
             if not self.isSameObject(event.source, obj):
                 if not self.isSameObject(obj, orca_state.locusOfFocus):
                     orca.setLocusOfFocus(event, obj, False)
-                    self.presentLine(obj, characterOffset)
+                    # If an alert got focus, let's do the best we can to 
+                    # try to automatically speak its contents while also
+                    # making sure the locus of focus and caret context
+                    # are in the right spot for braille and caret navigation.
+                    # http://bugzilla.gnome.org/show_bug.cgi?id=570551
+                    #
+                    if eventSourceRole == pyatspi.ROLE_ALERT:
+                        speech.speakUtterances(\
+                            self.speechGenerator.getSpeech(event.source, False))
+                        self.updateBraille(obj)
+                    else:
+                        self.presentLine(obj, characterOffset)
                 return
 
         default.Script.onFocus(self, event)

Modified: trunk/src/orca/scripts/toolkits/Gecko/speech_generator.py
==============================================================================
--- trunk/src/orca/scripts/toolkits/Gecko/speech_generator.py	(original)
+++ trunk/src/orca/scripts/toolkits/Gecko/speech_generator.py	Fri Feb 13 00:51:45 2009
@@ -108,6 +108,27 @@
 
         return utterances
 
+    def _getSpeechForAlert(self, obj, already_focused):
+        """Gets the speech for an alert.  What we do here is first try
+        to see if the alert contains text via embedded object characters.
+        If it does, we speak that text.  If it doesn't, we defer to the
+        super class.  The prototype alert we're shooting for is the one
+        from http://bugzilla.gnome.org/show_bug.cgi?id=570551
+
+        Arguments:
+        - obj: an Accessible
+        - already_focused: False if object just received focus
+
+        Returns a list of utterances to be spoken for the object.
+        """
+
+        text = self._script.expandEOCs(obj)
+        if text:
+            return [text]
+        else:
+            return speechgenerator.SpeechGenerator.\
+                       _getSpeechForAlert(self, obj, already_focused)
+
     def _getSpeechForDocumentFrame(self, obj, already_focused):
         """Gets the speech for a document frame.
 

Added: trunk/test/keystrokes/firefox/uiuc_alert.py
==============================================================================
--- (empty file)
+++ trunk/test/keystrokes/firefox/uiuc_alert.py	Fri Feb 13 00:51:45 2009
@@ -0,0 +1,97 @@
+#!/usr/bin/python
+
+"""Test of UIUC button presentation using Firefox.
+"""
+
+from macaroon.playback import *
+import utils
+
+sequence = MacroSequence()
+
+########################################################################
+# We wait for the focus to be on the Firefox window as well as for focus
+# to move to the "text/html: Button Example 1" frame.
+#
+sequence.append(WaitForWindowActivate(utils.firefoxFrameNames, None))
+
+########################################################################
+# Load the UIUC button demo.
+#
+sequence.append(KeyComboAction("<Control>l"))
+sequence.append(WaitForFocus(acc_role=pyatspi.ROLE_ENTRY))
+sequence.append(TypeAction("http://test.cita.uiuc.edu/aria/alertdialog/view_class.php?title=Alert%20Dialog%20Example%201:%20Number%20Guessing%20Game&ginc=includes/alertdialog1_class.inc&gcss=css/alertdialog1_class.css&gjs=../js/globals.js,../js/widgets_class.js,js/alertdialog1_class.js";))
+sequence.append(KeyComboAction("Return"))
+sequence.append(WaitForDocLoad())
+sequence.append(WaitForFocus("class: Alert Dialog Example 1: Number Guessing Game", acc_role=pyatspi.ROLE_DOCUMENT_FRAME))
+
+sequence.append(PauseAction(6000))
+
+########################################################################
+# Tab to the text area, enter some text and press return.
+#
+sequence.append(KeyComboAction("Tab"))
+sequence.append(WaitForFocus("Guess a number between 1 and 10", acc_role=pyatspi.ROLE_ENTRY))
+sequence.append(TypeAction("12"))
+sequence.append(utils.StartRecordingAction())
+sequence.append(KeyComboAction("Return"))
+sequence.append(WaitForFocus("Alert Box", acc_role=pyatspi.ROLE_ALERT))
+sequence.append(PauseAction(3000))
+sequence.append(utils.AssertPresentationAction(
+    "Open Alert Box", 
+    ["BRAILLE LINE:  'Alert Box'",
+     "     VISIBLE:  'Alert Box', cursor=1",
+     "SPEECH OUTPUT: ''",
+     "SPEECH OUTPUT: 'Alert Box12 is not between 1 and 10 '"]))
+
+########################################################################
+# Down arrow through the message and close button.
+#
+sequence.append(utils.StartRecordingAction())
+sequence.append(KeyComboAction("Down"))
+sequence.append(PauseAction(3000))
+sequence.append(utils.AssertPresentationAction(
+    "Down to message", 
+    ["BRAILLE LINE:  '12 is not between 1 and 10'",
+     "     VISIBLE:  '12 is not between 1 and 10', cursor=1",
+     "SPEECH OUTPUT: '12 is not between 1 and 10'"]))
+
+sequence.append(utils.StartRecordingAction())
+sequence.append(KeyComboAction("Down"))
+sequence.append(PauseAction(3000))
+sequence.append(utils.AssertPresentationAction(
+    "Down to close button", 
+    ["BRAILLE LINE:  'Close Button'",
+     "     VISIBLE:  'Close Button', cursor=1",
+     "SPEECH OUTPUT: 'Close button'"]))
+
+########################################################################
+# Close the alert.
+#
+sequence.append(utils.StartRecordingAction())
+sequence.append(KeyComboAction("Return"))
+sequence.append(PauseAction(3000))
+sequence.append(utils.AssertPresentationAction(
+    "Close Alert", 
+    ["BRAILLE LINE:  'Guess a number between 1 and 10 12 $l'",
+     "     VISIBLE:  'Guess a number between 1 and 10 ', cursor=0",
+     "BRAILLE LINE:  'Guess a number between 1 and 10 12 $l'",
+     "     VISIBLE:  'Guess a number between 1 and 10 ', cursor=0",
+     "SPEECH OUTPUT: ''",
+     "SPEECH OUTPUT: 'Guess a number between 1 and 10 text 12'"]))
+
+########################################################################
+# Close the demo
+#
+sequence.append(KeyComboAction("<Control>l"))
+sequence.append(WaitForFocus(acc_role=pyatspi.ROLE_ENTRY))
+sequence.append(TypeAction("about:blank"))
+sequence.append(KeyComboAction("Return"))
+sequence.append(WaitForDocLoad())
+
+# Just a little extra wait to let some events get through.
+#
+sequence.append(PauseAction(3000))
+
+sequence.append(utils.AssertionSummaryAction())
+
+sequence.start()