[gdm/multi-stack] Drop bogus conversation = NULL line
- From: Ray Strode <halfline src gnome org>
- To: svn-commits-list gnome org
- Subject: [gdm/multi-stack] Drop bogus conversation = NULL line
- Date: Tue, 16 Jun 2009 08:50:54 -0400 (EDT)
commit 8e97f2f6530738982e8ea4d977f7b749e9e36cf5
Author: Ray Strode <rstrode redhat com>
Date: Tue Jun 16 08:49:05 2009 -0400
Drop bogus conversation = NULL line
cancel_pending_query would set conversation to NULL
immediately before trying to use the conversation.
I probably introduced this bug when converting the
code over to work in terms of multiple conversation
objects instead of one conversation per session.
Spotted by Michael Young:
https://bugzilla.redhat.com/show_bug.cgi?id=499489#c9
daemon/gdm-session-direct.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/daemon/gdm-session-direct.c b/daemon/gdm-session-direct.c
index 9010dde..8710ac8 100644
--- a/daemon/gdm-session-direct.c
+++ b/daemon/gdm-session-direct.c
@@ -787,7 +787,6 @@ cancel_pending_query (GdmSessionConversation *conversation)
reply = dbus_message_new_error (conversation->message_pending_reply,
GDM_SESSION_DBUS_ERROR_CANCEL,
"Operation cancelled");
- conversation = NULL;
dbus_connection_send (conversation->worker_connection, reply, NULL);
dbus_connection_flush (conversation->worker_connection);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]