[pango/harfbuzz-ng] [HB] Correctly skip glyphs when applying (Chain)Context lookups
- From: Behdad Esfahbod <behdad src gnome org>
- To: svn-commits-list gnome org
- Subject: [pango/harfbuzz-ng] [HB] Correctly skip glyphs when applying (Chain)Context lookups
- Date: Mon, 18 May 2009 05:49:52 -0400 (EDT)
commit 55fdb2a9d8b9520d62bc1168709188baaf42790c
Author: Behdad Esfahbod <behdad behdad org>
Date: Mon May 18 04:15:25 2009 -0400
[HB] Correctly skip glyphs when applying (Chain)Context lookups
---
pango/opentype/hb-ot-layout-gsubgpos-private.h | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/pango/opentype/hb-ot-layout-gsubgpos-private.h b/pango/opentype/hb-ot-layout-gsubgpos-private.h
index 8d3cde7..e3143df 100644
--- a/pango/opentype/hb-ot-layout-gsubgpos-private.h
+++ b/pango/opentype/hb-ot-layout-gsubgpos-private.h
@@ -166,12 +166,20 @@ static inline bool apply_lookup (LOOKUP_ARGS_DEF,
{
unsigned int record_count = lookupCount;
const LookupRecord *record = lookupRecord;
+ unsigned int end = MIN (buffer->in_length, buffer->in_pos + context_length);
+ if (HB_UNLIKELY (buffer->in_pos + count > end))
+ return false;
- /* XXX We have to jump non-matching glyphs when applying too, right? */
/* TODO We don't support lookupRecord arrays that are not increasing:
* Should be easy for in_place ones at least. */
- for (unsigned int i = 0; i < count;)
- {
+ for (unsigned int i = 0; i < count; i++) {
+ while (!_hb_ot_layout_check_glyph_property (layout, IN_CURITEM (), lookup_flag, &property)) {
+ if (HB_UNLIKELY (buffer->in_pos == end))
+ return true;
+ /* No lookup applied for this index */
+ _hb_buffer_next_glyph (buffer);
+ }
+
if (record_count && i == record->sequenceIndex)
{
unsigned int old_pos = buffer->in_pos;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]