[rhythmbox] Fix crash in the new (empty) iPod dialog
- From: Christophe Fergeau <teuf src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [rhythmbox] Fix crash in the new (empty) iPod dialog
- Date: Wed, 7 Oct 2009 22:02:47 +0000 (UTC)
commit 0716ca596ce9b908df0c70047804895a0a6ea85c
Author: Christophe Fergeau <cfergeau mandriva com>
Date: Thu Oct 8 00:01:07 2009 +0200
Fix crash in the new (empty) iPod dialog
The GtkBuilder object containing the GUI for the new iPod dialog was reused
after being unref'ed which is a bad thing to do.
plugins/ipod/rb-ipod-helpers.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/plugins/ipod/rb-ipod-helpers.c b/plugins/ipod/rb-ipod-helpers.c
index e9260fe..9289252 100644
--- a/plugins/ipod/rb-ipod-helpers.c
+++ b/plugins/ipod/rb-ipod-helpers.c
@@ -244,6 +244,7 @@ rb_ipod_helpers_show_first_time_dialog (GMount *mount, const char *builder_file)
GtkBuilder *builder;
GtkWidget *dialog;
GtkWidget *widget;
+ GtkWidget *name_widget;
GtkTreeModel *tree_model;
GtkTreeIter iter;
int response;
@@ -273,6 +274,7 @@ rb_ipod_helpers_show_first_time_dialog (GMount *mount, const char *builder_file)
}
dialog = GTK_WIDGET (gtk_builder_get_object (builder, "ipod_init"));
widget = GTK_WIDGET (gtk_builder_get_object (builder, "model_combo"));
+ name_widget = GTK_WIDGET (gtk_builder_get_object (builder, "name_entry"));
fill_model_combo (widget, mountpoint);
g_object_unref (builder);
@@ -293,8 +295,7 @@ rb_ipod_helpers_show_first_time_dialog (GMount *mount, const char *builder_file)
return FALSE;
}
gtk_tree_model_get (tree_model, &iter, COL_INFO, &info, -1);
- widget = GTK_WIDGET (gtk_builder_get_object (builder, "name_entry"));
- ipod_name = g_strdup (gtk_entry_get_text (GTK_ENTRY (widget)));
+ ipod_name = g_strdup (gtk_entry_get_text (GTK_ENTRY (name_widget)));
gtk_widget_destroy (dialog);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]