[gdm/multi-stack: 35/38] Drop bogus conversation = NULL line
- From: Ray Strode <halfline src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [gdm/multi-stack: 35/38] Drop bogus conversation = NULL line
- Date: Wed, 21 Oct 2009 17:09:19 +0000 (UTC)
commit e5b85adb6e70809af080235c96f8d07df242c091
Author: Ray Strode <rstrode redhat com>
Date: Tue Jun 16 08:49:05 2009 -0400
Drop bogus conversation = NULL line
cancel_pending_query would set conversation to NULL
immediately before trying to use the conversation.
I probably introduced this bug when converting the
code over to work in terms of multiple conversation
objects instead of one conversation per session.
Spotted by Michael Young:
https://bugzilla.redhat.com/show_bug.cgi?id=499489#c9
daemon/gdm-session-direct.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/daemon/gdm-session-direct.c b/daemon/gdm-session-direct.c
index 7e9143b..6dc055b 100644
--- a/daemon/gdm-session-direct.c
+++ b/daemon/gdm-session-direct.c
@@ -790,7 +790,6 @@ cancel_pending_query (GdmSessionConversation *conversation)
reply = dbus_message_new_error (conversation->message_pending_reply,
GDM_SESSION_DBUS_ERROR_CANCEL,
"Operation cancelled");
- conversation = NULL;
dbus_connection_send (conversation->worker_connection, reply, NULL);
dbus_connection_flush (conversation->worker_connection);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]