[tracker] tracker-extract-mp3: Add missing break; when parsing id3v20 tags.
- From: Carlos Garnacho <carlosg src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [tracker] tracker-extract-mp3: Add missing break; when parsing id3v20 tags.
- Date: Wed, 28 Oct 2009 16:42:47 +0000 (UTC)
commit 3a52ea54ef40c96aaaf209dc26862d85bed81b0e
Author: Carlos Garnacho <carlos lanedo com>
Date: Wed Oct 28 15:28:42 2009 +0100
tracker-extract-mp3: Add missing break; when parsing id3v20 tags.
This could lead to doubly freed memory, since the same string was assigned
to genre and copyright.
src/tracker-extract/tracker-extract-mp3.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/src/tracker-extract/tracker-extract-mp3.c b/src/tracker-extract/tracker-extract-mp3.c
index 24bb051..f186f1c 100644
--- a/src/tracker-extract/tracker-extract-mp3.c
+++ b/src/tracker-extract/tracker-extract-mp3.c
@@ -1542,6 +1542,7 @@ get_id3v20_tags (const gchar *data,
case ID3V2_TCO:
{
gint genre;
+
if (get_genre_number (word, &genre)) {
g_free (word);
word = g_strdup (get_genre_name (genre));
@@ -1552,6 +1553,8 @@ get_id3v20_tags (const gchar *data,
} else {
g_free (word);
}
+
+ break;
}
case ID3V2_TCR:
tag->copyright = word;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]