[cheese] Removed most unneccessary warnings when compiling src/*

[Yuvaraj Pandian <yuvipanda src gnome org>]

commit 22096291bbf3deb10d2349f05196760a620fe81e
Author: Yuvaraj Pandian T <yuvipanda gmail com>
Date:   Tue Aug 3 03:09:37 2010 +0530

    Removed most unneccessary warnings when compiling src/*
    
    Warnings that remain point to real problems that should be handled

 src/cheese-preferences.vala |   21 +++++++++---------
 src/cheese-window.vala      |   48 +++++++++++++++++++++---------------------
 2 files changed, 34 insertions(+), 35 deletions(-)
---
diff --git a/src/cheese-preferences.vala b/src/cheese-preferences.vala
index 07ff5a4..588342b 100644
--- a/src/cheese-preferences.vala
+++ b/src/cheese-preferences.vala
@@ -21,7 +21,7 @@
 
 using Gtk;
 
-internal class Cheese.PreferencesDialog : GLib.Object
+public class Cheese.PreferencesDialog : GLib.Object
 {
   private Cheese.Camera camera;
   private Cheese.GConf  conf;
@@ -100,7 +100,6 @@ internal class Cheese.PreferencesDialog : GLib.Object
   private void initialize_camera_devices ()
   {
     Cheese.CameraDevice   dev;
-    TreeIter              active_dev;
     unowned GLib.PtrArray devices      = camera.get_camera_devices ();
     ListStore             camera_model = new ListStore (2, typeof (string), typeof (Cheese.CameraDevice));
 
@@ -159,7 +158,7 @@ internal class Cheese.PreferencesDialog : GLib.Object
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_source_change (Gtk.ComboBox combo)
+  public void on_source_change (Gtk.ComboBox combo)
   {
     TreeIter iter;
 
@@ -174,7 +173,7 @@ internal class Cheese.PreferencesDialog : GLib.Object
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_resolution_change (Gtk.ComboBox combo)
+  public void on_resolution_change (Gtk.ComboBox combo)
   {
     TreeIter iter;
 
@@ -189,46 +188,46 @@ internal class Cheese.PreferencesDialog : GLib.Object
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_dialog_close (Gtk.Button button)
+  public void on_dialog_close (Gtk.Button button)
   {
     this.dialog.hide_all ();
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_burst_repeat_change (Gtk.SpinButton spinbutton)
+  public void on_burst_repeat_change (Gtk.SpinButton spinbutton)
   {
     conf.gconf_prop_burst_repeat = (int) spinbutton.value;
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_burst_delay_change (Gtk.SpinButton spinbutton)
+  public void on_burst_delay_change (Gtk.SpinButton spinbutton)
   {
     conf.gconf_prop_burst_delay = (int) spinbutton.value * 1000;
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_brightness_change (Gtk.Adjustment adjustment)
+  public void on_brightness_change (Gtk.Adjustment adjustment)
   {
     this.camera.set_balance_property ("brightness", adjustment.value);
     conf.gconf_prop_brightness = adjustment.value;
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_contrast_change (Gtk.Adjustment adjustment)
+  public void on_contrast_change (Gtk.Adjustment adjustment)
   {
     this.camera.set_balance_property ("contrast", adjustment.value);
     conf.gconf_prop_contrast = adjustment.value;
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_hue_change (Gtk.Adjustment adjustment)
+  public void on_hue_change (Gtk.Adjustment adjustment)
   {
     this.camera.set_balance_property ("hue", adjustment.value);
     conf.gconf_prop_hue = adjustment.value;
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_saturation_change (Gtk.Adjustment adjustment)
+  public void on_saturation_change (Gtk.Adjustment adjustment)
   {
     this.camera.set_balance_property ("saturation", adjustment.value);
     conf.gconf_prop_saturation = adjustment.value;
diff --git a/src/cheese-window.vala b/src/cheese-window.vala
index 21e2aa5..e58fdde 100644
--- a/src/cheese-window.vala
+++ b/src/cheese-window.vala
@@ -57,7 +57,7 @@ public class Cheese.MainWindow : Gtk.Window
   private Gtk.ToggleButton effects_toggle_button;
   private Gtk.Button       leave_fullscreen_button;
   private Gtk.HBox         buttons_area;
-  private Gtk.Menu         popup_menu;
+  private Gtk.Menu         thumbnail_popup;
 
   private Clutter.Stage     viewport;
   private Clutter.Box       viewport_layout;
@@ -100,20 +100,20 @@ public class Cheese.MainWindow : Gtk.Window
   private Cheese.Effect selected_effect;
 
   [CCode (instance_pos = -1)]
-  internal void on_quit (Gtk.Action action)
+  public void on_quit (Gtk.Action action)
   {
     destroy ();
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_preferences_dialog (Gtk.Action action)
+  public void on_preferences_dialog (Gtk.Action action)
   {
     if (preferences_dialog == null)
       preferences_dialog = new Cheese.PreferencesDialog (camera, conf);
     preferences_dialog.show ();
   }
 
-  internal bool on_thumbnail_mouse_button_press (Gtk.Widget      iconview,
+  public bool on_thumbnail_mouse_button_press (Gtk.Widget      iconview,
                                                  Gdk.EventButton event)
   {
     Gtk.TreePath path;
@@ -133,7 +133,7 @@ public class Cheese.MainWindow : Gtk.Window
     {
       if (event.button == 3)
       {
-        popup_menu.popup (null, thumb_view, null, event.button, event.time);
+        thumbnail_popup.popup (null, thumb_view, null, event.button, event.time);
       }
     }
     else
@@ -146,7 +146,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_file_open (Gtk.Action ? action)
+  public void on_file_open (Gtk.Action ? action)
   {
     string filename, uri;
 
@@ -163,7 +163,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_file_delete (Gtk.Action action)
+  public void on_file_delete (Gtk.Action action)
   {
     string        filename, basename;
     MessageDialog confirmation_dialog;
@@ -192,7 +192,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_file_move_to_trash (Gtk.Action action)
+  public void on_file_move_to_trash (Gtk.Action action)
   {
     string filename;
 
@@ -205,7 +205,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_file_move_to_trash_all (Gtk.Action action)
+  public void on_file_move_to_trash_all (Gtk.Action action)
   {
     try {
       File           file_to_trash;
@@ -235,7 +235,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_file_save_as (Gtk.Action action)
+  public void on_file_save_as (Gtk.Action action)
   {
     string            filename, basename;
     FileChooserDialog save_as_dialog;
@@ -289,7 +289,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_help_contents (Gtk.Action action)
+  public void on_help_contents (Gtk.Action action)
   {
     Gdk.Screen screen;
     screen = this.get_screen ();
@@ -302,7 +302,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_help_about (Gtk.Action action)
+  public void on_help_about (Gtk.Action action)
   {
     /* FIXME: Close doesn't work
      * FIXME: Clicking URL In the License dialog borks. */
@@ -314,19 +314,19 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_layout_wide_mode (ToggleAction action)
+  public void on_layout_wide_mode (ToggleAction action)
   {
     set_wide_mode (action.active);
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_layout_fullscreen (ToggleAction action)
+  public void on_layout_fullscreen (ToggleAction action)
   {
     set_fullscreen_mode (action.active);
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_mode_change (RadioAction action)
+  public void on_mode_change (RadioAction action)
   {
     set_mode ((MediaMode) action.value);
   }
@@ -528,7 +528,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   /* To make sure that the layout manager manages the entire stage. */
-  internal void on_stage_resize (Clutter.Actor           actor,
+  public void on_stage_resize (Clutter.Actor           actor,
                                  Clutter.ActorBox        box,
                                  Clutter.AllocationFlags flags)
   {
@@ -539,7 +539,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_countdown_toggle (ToggleAction action)
+  public void on_countdown_toggle (ToggleAction action)
   {
     conf.gconf_prop_countdown = action.active;
   }
@@ -552,7 +552,7 @@ public class Cheese.MainWindow : Gtk.Window
     this.camera.take_photo (file_name);
   }
 
-  internal void take_photo ()
+  public void take_photo ()
   {
     if (conf.gconf_prop_countdown)
     {
@@ -588,7 +588,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_take_action (Gtk.Action action)
+  public void on_take_action (Gtk.Action action)
   {
     if (current_mode == MediaMode.PHOTO)
     {
@@ -631,7 +631,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_effects_toggle (Gtk.ToggleAction action)
+  public void on_effects_toggle (Gtk.ToggleAction action)
   {
     toggle_effects_selector (action.active);
     take_photo_action.sensitive = !action.active;
@@ -642,7 +642,7 @@ public class Cheese.MainWindow : Gtk.Window
     burst_mode_action.sensitive = !action.active;
   }
 
-  internal bool on_selected_effect_change (Clutter.ButtonEvent event)
+  public bool on_selected_effect_change (Clutter.ButtonEvent event)
   {
     selected_effect = event.source.get_data ("effect");
     camera.set_effect (selected_effect);
@@ -651,7 +651,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_prev_effects_page (Gtk.Action action)
+  public void on_prev_effects_page (Gtk.Action action)
   {
     if (current_effects_page != 0)
     {
@@ -660,7 +660,7 @@ public class Cheese.MainWindow : Gtk.Window
   }
 
   [CCode (instance_pos = -1)]
-  internal void on_next_effects_page (Gtk.Action action)
+  public void on_next_effects_page (Gtk.Action action)
   {
     if (current_effects_page != (effects_manager.effects.size / EFFECTS_PER_PAGE))
     {
@@ -837,7 +837,7 @@ public class Cheese.MainWindow : Gtk.Window
     effects_toggle_button             = (Gtk.ToggleButton)gtk_builder.get_object ("effects_toggle_button");
     leave_fullscreen_button           = (Gtk.Button)gtk_builder.get_object ("leave_fullscreen_button");
     buttons_area                      = (Gtk.HBox)gtk_builder.get_object ("buttons_area");
-    popup_menu                        = (Gtk.Menu)gtk_builder.get_object ("thumbnail_popup");
+    thumbnail_popup                        = (Gtk.Menu)gtk_builder.get_object ("thumbnail_popup");
 
     take_photo_action        = (Gtk.Action)gtk_builder.get_object ("take_photo");
     take_video_action        = (Gtk.Action)gtk_builder.get_object ("take_video");