[vala/switch-to-gir] girparser: Add missing 'continue' when skipping parameter
- From: Luca Bruno <lucabru src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [vala/switch-to-gir] girparser: Add missing 'continue' when skipping parameter
- Date: Thu, 26 Aug 2010 21:56:51 +0000 (UTC)
commit 4582e9516d1f3aab17b8de3c8a75c7f6606699f2
Author: Luca Bruno <lethalman88 gmail com>
Date: Thu Aug 26 23:56:33 2010 +0200
girparser: Add missing 'continue' when skipping parameter
vala/valagirparser.vala | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
---
diff --git a/vala/valagirparser.vala b/vala/valagirparser.vala
index e7ad581..b0ac334 100644
--- a/vala/valagirparser.vala
+++ b/vala/valagirparser.vala
@@ -32,6 +32,13 @@ using GLib;
* 4) Reparent nodes
* 5) Process callbacks/virtual
* 6) Process aliases
+ *
+ * Best hacking practices:
+ * - Keep GIR parsing bloat-free, it must contain the logic
+ * - Prefer being clean / short over performance
+ * - Try to make things common as much as possible
+ * - Prefer parse+replace rather than a bunch of if-then-else
+ * - Prefer postprocessing over hardcoding the parser
*/
public class Vala.GirParser : CodeVisitor {
enum MetadataType {
@@ -1750,6 +1757,7 @@ public class Vala.GirParser : CodeVisitor {
while (current_token == MarkupTokenType.START_ELEMENT) {
if (!push_metadata ()) {
skip_element ();
+ continue;
}
m.add_parameter (parse_parameter ());
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]