[libgda] PostgresProvider: Do not set GErrors without a domain.
- From: Murray Cumming <murrayc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libgda] PostgresProvider: Do not set GErrors without a domain.
- Date: Fri, 26 Feb 2010 22:42:54 +0000 (UTC)
commit 7e7e61fb646a82a2cfaec1033d3f548f411a5ffa
Author: Murray Cumming <murrayc murrayc com>
Date: Sun Jan 24 20:26:51 2010 +0100
PostgresProvider: Do not set GErrors without a domain.
* providers/postgres/gda-postgres-provider.c:
gda_postgres_provider_create_operation(),
gda_postgres_provider_render_operation(),
gda_postgres_provider_perform_operation():
Use GErorr domain=GDA_SERVER_PROVIDER_ERROR and
code=GDA_SERVER_PROVIDER_OPERATION_ERROR instead of 0, 0 for
generic errors, because that is what users of GdaServerProvider
expect.
providers/postgres/gda-postgres-provider.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/providers/postgres/gda-postgres-provider.c b/providers/postgres/gda-postgres-provider.c
index 6a82fa5..9c0ce6c 100644
--- a/providers/postgres/gda-postgres-provider.c
+++ b/providers/postgres/gda-postgres-provider.c
@@ -737,7 +737,7 @@ gda_postgres_provider_create_operation (GdaServerProvider *provider, GdaConnecti
g_free (dir);
if (! file) {
- g_set_error (error, 0, 0, _("Missing spec. file '%s'"), str);
+ g_set_error (error, GDA_SERVER_PROVIDER_ERROR, GDA_SERVER_PROVIDER_OPERATION_ERROR, _("Missing spec. file '%s'"), str);
g_free (str);
return NULL;
}
@@ -776,7 +776,7 @@ gda_postgres_provider_render_operation (GdaServerProvider *provider, GdaConnecti
g_free (dir);
if (! file) {
- g_set_error (error, 0, 0, _("Missing spec. file '%s'"), str);
+ g_set_error (error, GDA_SERVER_PROVIDER_ERROR, GDA_SERVER_PROVIDER_OPERATION_ERROR, _("Missing spec. file '%s'"), str);
g_free (str);
return NULL;
}
@@ -913,7 +913,7 @@ gda_postgres_provider_perform_operation (GdaServerProvider *provider, GdaConnect
g_string_free (string, TRUE);
if (PQstatus (pconn) != CONNECTION_OK) {
- g_set_error (error, 0, 0, "%s", PQerrorMessage (pconn));
+ g_set_error (error, GDA_SERVER_PROVIDER_ERROR, GDA_SERVER_PROVIDER_OPERATION_ERROR, "%s", PQerrorMessage (pconn));
PQfinish(pconn);
return FALSE;
@@ -927,7 +927,7 @@ gda_postgres_provider_perform_operation (GdaServerProvider *provider, GdaConnect
pg_res = _gda_postgres_PQexec_wrap (cnc, pconn, sql);
g_free (sql);
if (!pg_res || PQresultStatus (pg_res) != PGRES_COMMAND_OK) {
- g_set_error (error, 0, 0, "%s", PQresultErrorMessage (pg_res));
+ g_set_error (error, GDA_SERVER_PROVIDER_ERROR, GDA_SERVER_PROVIDER_OPERATION_ERROR, "%s", PQresultErrorMessage (pg_res));
PQfinish (pconn);
return FALSE;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]