[gnome-color-manager] trivial: fix an error spotted with clang



commit a8f6e29a219b5fc9784a5c91becde9f612ffcf7a
Author: Richard Hughes <richard hughsie com>
Date:   Fri Jan 1 19:01:28 2010 +0000

    trivial: fix an error spotted with clang

 src/gcm-prefs.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/gcm-prefs.c b/src/gcm-prefs.c
index 1089d7e..b249c27 100644
--- a/src/gcm-prefs.c
+++ b/src/gcm-prefs.c
@@ -98,7 +98,7 @@ static gboolean
 gcm_prefs_set_default (GcmDevice *device)
 {
 	GError *error = NULL;
-	gboolean ret;
+	gboolean ret = FALSE;
 	gchar *cmdline = NULL;
 	gchar *filename = NULL;
 	gchar *id = NULL;
@@ -111,8 +111,10 @@ gcm_prefs_set_default (GcmDevice *device)
 		      NULL);
 
 	/* nothing set */
-	if (filename == NULL)
+	if (filename == NULL) {
+		egg_debug ("no filename for %s", id);
 		goto out;
+	}
 
 	/* run using PolicyKit */
 	cmdline = g_strdup_printf ("pkexec %s --id %s \"%s\"", install_cmd, id, filename);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]