[gtkmm] Widget: Un-deprecate get_action().



commit 0ada2031bb83d0b76863e162b0217e58e0aa8906
Author: Murray Cumming <murrayc murrayc com>
Date:   Wed Jan 27 11:18:53 2010 +0100

    Widget: Un-deprecate get_action().
    
    * gtk/src/widget.hg: get_action(): Do not deprecate this because we
    cannot yet use its replacement (adding Activatable as a base class).
    Do not try to wrap a gtk_widget_get_related_action() function which
    no longer exists, if it ever did.
    * gtk/src/activatable.hg: Add a TODO to use this, though we
    already have TODOs on the widgets that should use it when we can break
    ABI.

 ChangeLog              |   12 ++++++++++++
 gtk/src/activatable.hg |    3 ++-
 gtk/src/widget.hg      |    9 +++------
 3 files changed, 17 insertions(+), 7 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index d0ffebe..34b70e1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2010-01-27  Murray Cumming  <murrayc murrayc com>
+
+	Widget: Un-deprecate get_action().
+
+	* gtk/src/widget.hg: get_action(): Do not deprecate this because we 
+	cannot yet use its replacement (adding Activatable as a base class).
+	Do not try to wrap a gtk_widget_get_related_action() function which 
+	no longer exists, if it ever did.
+	* gtk/src/activatable.hg: Add a TODO to use this, though we 
+	already have TODOs on the widgets that should use it when we can break 
+	ABI.
+
 2.19.4:
 
 2010-01-25  Murray Cumming  <murrayc murrayc com>
diff --git a/gtk/src/activatable.hg b/gtk/src/activatable.hg
index 87d0605..080dbe9 100644
--- a/gtk/src/activatable.hg
+++ b/gtk/src/activatable.hg
@@ -27,7 +27,8 @@ _PINCLUDE(glibmm/private/interface_p.h)
 namespace Gtk
 {
 
-/** Activatable widgets can be connected to a GtkAction and reflect the state 
+//TODO: Use this when we can add new base classes to existing classes.
+/** Activatable widgets can be connected to a Gtk::Action and reflect the state 
  * of the action. An Activatable can also provide feedback through its action, 
  * as it is responsible for activating the related action.
  *
diff --git a/gtk/src/widget.hg b/gtk/src/widget.hg
index ffff948..37d93b3 100644
--- a/gtk/src/widget.hg
+++ b/gtk/src/widget.hg
@@ -649,12 +649,9 @@ _DEPRECATE_IFDEF_START
 
   _WRAP_METHOD(bool is_composited() const, gtk_widget_is_composited)
 
-  _WRAP_METHOD(Glib::RefPtr<Action> get_action(), gtk_widget_get_action, refreturn, deprecated)
-  _WRAP_METHOD(Glib::RefPtr<const Action> get_action() const, gtk_widget_get_action, refreturn, constversion, deprecated)
-
-  _WRAP_METHOD(Glib::RefPtr<Action> get_related_action(), gtk_widget_get_related_action, refreturn)
-  _WRAP_METHOD(Glib::RefPtr<const Action> get_related_action() const, gtk_widget_get_related_action, refreturn, constversion)
-
+  //TODO: Deprecate this when the other widgets can derive from Gtk::Activatable. 
+  _WRAP_METHOD(Glib::RefPtr<Action> get_action(), gtk_widget_get_action, refreturn)
+  _WRAP_METHOD(Glib::RefPtr<const Action> get_action() const, gtk_widget_get_action, refreturn, constversion)
 
   _MEMBER_GET(saved_state, saved_state, Gtk::StateType, guint8)
   _MEMBER_GET(requisition, requisition, Requisition, GtkRequisition)



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]