[tracker] libtracker-common: If error splicing, let user callback free it
- From: Aleksander Morgado <aleksm src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [tracker] libtracker-common: If error splicing, let user callback free it
- Date: Tue, 20 Jul 2010 08:19:01 +0000 (UTC)
commit e828d6b18199b9471e5175129161a35daa43eea6
Author: Aleksander Morgado <aleksander lanedo com>
Date: Tue Jul 20 10:18:38 2010 +0200
libtracker-common: If error splicing, let user callback free it
src/libtracker-common/tracker-dbus.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/src/libtracker-common/tracker-dbus.c b/src/libtracker-common/tracker-dbus.c
index ce2c3dd..c670539 100644
--- a/src/libtracker-common/tracker-dbus.c
+++ b/src/libtracker-common/tracker-dbus.c
@@ -890,7 +890,10 @@ send_and_splice_async_callback (GObject *source,
(* data->callback) (NULL, -1, error, data->user_data);
- g_error_free (error);
+ /* Note: GError should be freed by callback. We do this to be aligned
+ * with the behavior of dbus-glib, where if an error happens, the
+ * GError passed to the callback is supposed to be disposed by the
+ * callback itself. */
}
if (reply) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]