[seed] Change null into a warning for the time being, due to gir's need to catch up



commit 2c46218b7459d0f47b9ae5043c38e8f797c1a293
Author: Alan Knowles <alan alanfast akbkhome com>
Date:   Mon Mar 1 17:06:01 2010 +0800

    Change null into a warning for the time being, due to gir's need to catch up
    
    Introspection tells us which arguments can be null, however the gir's for most packages have not been
    updated to show this (Gtk had a big patchfest last week to add this, but it will not be reflected on end users
    desktop gir's for a while) - until then we issue g_warnings.

 libseed/seed-engine.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)
---
diff --git a/libseed/seed-engine.c b/libseed/seed-engine.c
index b941414..5caa79f 100644
--- a/libseed/seed-engine.c
+++ b/libseed/seed-engine.c
@@ -537,14 +537,16 @@ seed_gobject_method_invoked (JSContextRef ctx,
 
               if (is_null) 
                 {
-                  seed_make_exception (ctx, exception,
-				   "ArgumentError",
+                  // RE-INSTATE THIS CODE LATER.. - when gtk etc. has be release with fixes
+		  //seed_make_exception (ctx, exception,
+		  //   "ArgumentError",
+                  g_warning(      "ArgumentError - probably due to incorrect gir file (which may be fixed upstream)"
 				   " argument %d must not be null for"
 				   " function: %s. \n",
 				   i + 1,
 				   g_base_info_get_name ((GIBaseInfo *)
 							 info));
-                  goto arg_error;
+                  //goto arg_error;
                 }
             }
 
@@ -558,7 +560,9 @@ seed_gobject_method_invoked (JSContextRef ctx,
 				   i + 1,
 				   g_base_info_get_name ((GIBaseInfo *)
 							 info));
- arg_error:
+
+// FIXME - SEE NOTE ABOVE ABOUT gtk allow_null bugs
+// arg_error:
 	      g_base_info_unref ((GIBaseInfo *) type_info);
 	      g_base_info_unref ((GIBaseInfo *) arg_info);
 	      g_free (in_args);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]