[nautilus-actions] Fix bug when reordering profiles inside of an action
- From: Pierre Wieser <pwieser src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nautilus-actions] Fix bug when reordering profiles inside of an action
- Date: Wed, 24 Mar 2010 19:14:51 +0000 (UTC)
commit f3e874061f27970065ae6316cc5a17aac099431d
Author: Pierre Wieser <pwieser trychlos org>
Date: Wed Mar 24 20:16:14 2010 +0100
Fix bug when reordering profiles inside of an action
Not only unref the old origin of the saved item, but also removes it from NAPivot.
ChangeLog | 5 +++++
TODO | 4 +++-
src/nact/nact-main-menubar.c | 2 +-
3 files changed, 9 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index c2c60d0..2c095e1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2009-03-24 Pierre Wieser <pwieser trychlos org>
+
+ * src/nact/nact-main-menubar.c (save_item):
+ Not only unref old origin, but also remove it from tree.
+
2009-03-23 Pierre Wieser <pwieser trychlos org>
Add buttons to sort the list.
diff --git a/TODO b/TODO
index c6206c4..1ab1932 100644
--- a/TODO
+++ b/TODO
@@ -140,4 +140,6 @@
- bug: when order changes, nact is not marked modified
-- bug: when profile order changes, an unref is warned at end
+- bug: when we change order via preferences, the buttons should reflect this
+
+- bug: when one clicks on target location, no more able to cut paste
diff --git a/src/nact/nact-main-menubar.c b/src/nact/nact-main-menubar.c
index 4ec27a6..d813d94 100644
--- a/src/nact/nact-main-menubar.c
+++ b/src/nact/nact-main-menubar.c
@@ -988,7 +988,7 @@ save_item( NactMainWindow *window, NAUpdater *updater, NAObjectItem *item )
if( parent ){
pos = na_object_get_position( parent, origin );
}
- g_object_unref( origin );
+ na_updater_remove_item( updater, NA_OBJECT( origin ));
}
dup_pivot = NA_OBJECT_ITEM( na_object_duplicate( item ));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]