[nautilus-actions] Remove not used selection_changed interface API



commit fbb706110d4d66fd3cfa37473f57b465d08102a3
Author: Pierre Wieser <pwieser trychlos org>
Date:   Wed Mar 24 22:35:10 2010 +0100

    Remove not used selection_changed interface API

 ChangeLog                     |    5 +++++
 src/nact/nact-iactions-list.c |   21 ---------------------
 src/nact/nact-iactions-list.h |   17 -----------------
 3 files changed, 5 insertions(+), 38 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 1368398..c74d31a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2009-03-24 Pierre Wieser <pwieser trychlos org>
 
+	* src/nact/nact-iactions-list.c:
+	* src/nact/nact-iactions-list.h
+	(selection_changed): Remove the not used API.
+	Remove the connection to the signal and the call to the interface.
+
 	* src/nact/nact-main-window.c
 	(ipivot_consumer_on_display_order_changed):
 	Relay NAIPivotConsumer notification to nact_sort_buttons.
diff --git a/src/nact/nact-iactions-list.c b/src/nact/nact-iactions-list.c
index f5ac29c..5b30b5c 100644
--- a/src/nact/nact-iactions-list.c
+++ b/src/nact/nact-iactions-list.c
@@ -98,7 +98,6 @@ static gboolean on_focus_in( GtkWidget *widget, GdkEventFocus *event, NactIActio
 static gboolean on_focus_out( GtkWidget *widget, GdkEventFocus *event, NactIActionsList *instance );
 static gboolean on_key_pressed_event( GtkWidget *widget, GdkEventKey *event, NactIActionsList *instance );
 static void     on_label_edited( GtkCellRendererText *renderer, const gchar *path, const gchar *text, NactIActionsList *instance );
-static void     on_iactions_list_selection_changed( NactIActionsList *instance, GSList *selected_items );
 static void     on_tab_updatable_item_updated( NactIActionsList *instance, NAObject *object, gboolean force_display );
 static void     open_popup( NactIActionsList *instance, GdkEventButton *event );
 
@@ -448,13 +447,6 @@ nact_iactions_list_runtime_init_toplevel( NactIActionsList *instance, GList *ite
 				"button-press-event",
 				G_CALLBACK( on_button_press_event ));
 
-		/* install a virtual function as 'selection-changed' handler */
-		base_window_signal_connect(
-				BASE_WINDOW( instance ),
-				G_OBJECT( instance ),
-				IACTIONS_LIST_SIGNAL_SELECTION_CHANGED,
-				G_CALLBACK( on_iactions_list_selection_changed ));
-
 		/* updates the treeview display when an item is modified */
 		ialid->tab_updated_handler = base_window_signal_connect(
 				BASE_WINDOW( instance ),
@@ -1250,19 +1242,6 @@ on_label_edited( GtkCellRendererText *renderer, const gchar *path_str, const gch
 }
 
 /*
- * our handler for "selection-changed" emitted by the interface
- * this let us transform the signal in a virtual function
- * so that our implementors have the best of two worlds ;-)
- */
-static void
-on_iactions_list_selection_changed( NactIActionsList *instance, GSList *selected_items )
-{
-	if( NACT_IACTIONS_LIST_GET_INTERFACE( instance )->selection_changed ){
-		NACT_IACTIONS_LIST_GET_INTERFACE( instance )->selection_changed( instance, selected_items );
-	}
-}
-
-/*
  * an item has been updated in one of the tabs
  * update the treeview to reflects its new edition status
  */
diff --git a/src/nact/nact-iactions-list.h b/src/nact/nact-iactions-list.h
index 8abc64b..0926ea8 100644
--- a/src/nact/nact-iactions-list.h
+++ b/src/nact/nact-iactions-list.h
@@ -70,23 +70,6 @@ typedef struct {
 	NactIActionsListInterfacePrivate *private;
 
 	/**
-	 * selection_changed:
-	 * @instance: this #NactIActionsList implementor.
-	 * @selected_items: currently selected items.
-	 *
-	 * This function is an exact duplicate of the
-	 * "nact-iactions-list-selection-changed" signal. Implementor may
-	 * choose to to connect to the signal, or to implement this api, in
-	 * order to be triggered when the selection is modified in the
-	 * treeview.
-	 *
-	 * Be warned that both implementing the api and connecting to the
-	 * signal must be considered at least as useless, and just a way to
-	 * be triggered twice for the same event.
-	 */
-	void    ( *selection_changed )( NactIActionsList *instance, GSList *selected_items );
-
-	/**
 	 * get_treeview_name:
 	 * @instance: this #NactIActionsList implementor.
 	 *



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]