[goffice] go-conf: Implement conf notification in keyfile case.

[Morten Welinder <mortenw src gnome org>]

commit 5dfe00ebe9db232f86cd7a8821699ab6b60a1f5b
Author: Morten Welinder <terra gnome org>
Date:   Thu Mar 25 08:21:05 2010 -0400

    go-conf: Implement conf notification in keyfile case.

 ChangeLog                     |    5 ++
 NEWS                          |    9 ++-
 goffice/app/go-conf-gconf.c   |   24 ++++-----
 goffice/app/go-conf-keyfile.c |  107 +++++++++++++++++++++++++++++++++++-----
 goffice/app/go-conf.c         |   16 ++++++
 5 files changed, 130 insertions(+), 31 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index c31ab44..401801d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2010-03-25  Morten Welinder  <terra gnome org>
+
+	* goffice/app/go-conf-keyfile.c (go_conf_add_monitor,
+	go_conf_remove_monitor): Implement for intra-process changes.
+
 2010-03-25  Valek Filippov  <frob gnome org>
 
 	* goffice/canvas/goc-polygon.c: support for fill rule.
diff --git a/NEWS b/NEWS
index 8d12fdd..8e407f2 100644
--- a/NEWS
+++ b/NEWS
@@ -3,10 +3,13 @@ goffice 0.8.2:
 Jean:
 	* Support fd:// URIs on win32. [#608422]
 
+Morten:
+	* Implement conf notification in keyfile case.  [#613523]
+
 Valek:
-	* Fix distance calculation for arc, ellipse, polygon, polyline and
-	rectangle
-	* Support rotation for text
+	* Fix distance calculation for arc, ellipse, polygon, polyline,
+	  and rectangle.
+	* Support rotation for text on canvas.
 
 --------------------------------------------------------------------------
 goffice 0.8.1:
diff --git a/goffice/app/go-conf-gconf.c b/goffice/app/go-conf-gconf.c
index 9b53ec8..27330cf 100644
--- a/goffice/app/go-conf-gconf.c
+++ b/goffice/app/go-conf-gconf.c
@@ -432,17 +432,13 @@ go_conf_remove_monitor (guint monitor_id)
 		GPOINTER_TO_INT (monitor_id));
 }
 
-typedef struct {
-	GOConfMonitorFunc monitor;
-	GOConfNode *node;
-	gpointer data;
-} GOConfClosure;
-
 static void
-cb_key_changed (GConfClient *client, guint cnxn_id,
-		GConfEntry *entry, GOConfClosure *cls)
+cb_key_changed (GConfClient *client,
+		G_GNUC_UNUSED guint cnxn_id,
+		G_GNUC_UNUSED GConfEntry *entry,
+		GOConfClosure *cls)
 {
-	cls->monitor (cls->node, gconf_entry_get_key (entry), cls->data);
+	cls->monitor (cls->node, cls->real_key, cls->data);
 }
 
 guint
@@ -451,7 +447,6 @@ go_conf_add_monitor (GOConfNode *node, gchar const *key,
 {
 	guint ret;
 	GOConfClosure *cls;
-	gchar *real_key;
 
 	g_return_val_if_fail (node || key, 0);
 	g_return_val_if_fail (monitor != NULL, 0);
@@ -460,11 +455,12 @@ go_conf_add_monitor (GOConfNode *node, gchar const *key,
 	cls->monitor = monitor;
 	cls->node = node;
 	cls->data = data;
-	real_key = go_conf_get_real_key (node, key);
+	cls->key = g_strdup (key);
+	cls->real_key = go_conf_get_real_key (node, key);
 	ret = gconf_client_notify_add
-		(gconf_client, real_key, (GConfClientNotifyFunc)cb_key_changed,
-		 cls, g_free, NULL);
-	g_free (real_key);
+		(gconf_client,
+		 cls->real_key, (GConfClientNotifyFunc)cb_key_changed,
+		 cls, (GDestroyNotify)go_conf_closure_free, NULL);
 
 	return ret;
 }
diff --git a/goffice/app/go-conf-keyfile.c b/goffice/app/go-conf-keyfile.c
index f837a81..84a4e28 100644
--- a/goffice/app/go-conf-keyfile.c
+++ b/goffice/app/go-conf-keyfile.c
@@ -17,6 +17,28 @@ struct _GOConfNode {
 
 static GHashTable *key_files = NULL;
 
+static GHashTable *key_monitor_by_id = NULL;
+static GHashTable *key_monitors_by_path = NULL;
+static guint key_monitors_id = 0;
+
+static void
+signal_monitors (const char *real_key)
+{
+	GSList *cls;
+
+	for (cls = g_hash_table_lookup (key_monitors_by_path, real_key);
+	     cls;
+	     cls = cls->next) {
+		GOConfClosure *cl = cls->data;
+#if 0
+		g_printerr ("Signal for %s to %p\n",
+			    cl->real_key, cl->monitor);
+#endif
+		cl->monitor (cl->node, cl->real_key, cl->data);
+	}
+}
+
+
 static gchar *get_rc_filename (char const *root_name)
 {
 	const gchar *home = g_get_home_dir ();
@@ -116,10 +138,8 @@ go_conf_set_bool (GOConfNode *node, gchar const *key, gboolean val)
 {
 	gchar *real_key = go_conf_get_real_key (node, key);
 
-	if (node == NULL)
-		return;
-
 	g_key_file_set_boolean (node->key_file, BOOL_GROUP, real_key, val);
+	signal_monitors (real_key);
 	g_free (real_key);
 }
 
@@ -128,10 +148,8 @@ go_conf_set_int (GOConfNode *node, gchar const *key, gint val)
 {
 	gchar *real_key = go_conf_get_real_key (node, key);
 
-	if (node == NULL)
-		return;
-
 	g_key_file_set_integer (node->key_file, INT_GROUP, real_key, val);
+	signal_monitors (real_key);
 	g_free (real_key);
 }
 
@@ -141,11 +159,9 @@ go_conf_set_double (GOConfNode *node, gchar const *key, gdouble val)
 	gchar *real_key = go_conf_get_real_key (node, key);
 	gchar str[G_ASCII_DTOSTR_BUF_SIZE];
 
-	if (node == NULL)
-		return;
-
 	g_ascii_dtostr (str, sizeof (str), val);
 	g_key_file_set_value (node->key_file, DOUBLE_GROUP, real_key, str);
+	signal_monitors (real_key);
 	g_free (real_key);
 }
 
@@ -154,10 +170,8 @@ go_conf_set_string (GOConfNode *node, gchar const *key, char const *str)
 {
 	gchar *real_key = go_conf_get_real_key (node, key);
 
-	if (node == NULL)
-		return;
-
 	g_key_file_set_string (node->key_file, STRING_GROUP, real_key, str);
+	signal_monitors (real_key);
 	g_free (real_key);
 }
 
@@ -168,7 +182,8 @@ go_conf_set_str_list (GOConfNode *node, gchar const *key, GSList *list)
 	gchar **strs = NULL;
 	int i, ns;
 
-	if (node == NULL || list == NULL)
+	/* eh? */
+	if (list == NULL)
 		return;
 
 	real_key = go_conf_get_real_key (node, key);
@@ -183,6 +198,7 @@ go_conf_set_str_list (GOConfNode *node, gchar const *key, GSList *list)
 
 	g_key_file_set_string_list (node->key_file, STRLIST_GROUP, real_key,
 				    (gchar const **const) strs, ns);
+	signal_monitors (real_key);
 	g_free (real_key);
 
 	for (i = 0; i < ns; i++)
@@ -492,11 +508,74 @@ go_conf_sync (GOConfNode *node)
 void
 go_conf_remove_monitor (guint monitor_id)
 {
+	GOConfClosure *cl = key_monitor_by_id
+		? g_hash_table_lookup (key_monitor_by_id,
+				       GUINT_TO_POINTER (monitor_id))
+		: NULL;
+	GSList *cls;
+
+	g_return_if_fail (cl != NULL);
+
+	g_hash_table_remove (key_monitor_by_id,
+			     GUINT_TO_POINTER (monitor_id));
+	if (g_hash_table_size (key_monitor_by_id) == 0) {
+		g_hash_table_destroy (key_monitor_by_id);
+		key_monitor_by_id = NULL;
+	}
+
+	cls = g_hash_table_lookup (key_monitors_by_path, cl->real_key);
+	cls = g_slist_remove (cls, cl);
+	if (cls)
+		g_hash_table_replace (key_monitors_by_path,
+				      g_strdup (cl->real_key),
+				      cls);
+	else
+		g_hash_table_remove (key_monitors_by_path, cl->real_key);
+	go_conf_closure_free (cl);
+
+	if (g_hash_table_size (key_monitors_by_path) == 0) {
+		g_hash_table_destroy (key_monitors_by_path);
+		key_monitors_by_path = NULL;
+	}
 }
 
 guint
 go_conf_add_monitor (GOConfNode *node, gchar const *key,
 		     GOConfMonitorFunc monitor, gpointer data)
 {
-	return 1;
+	GOConfClosure *cl;
+	GSList *cls;
+	guint res;
+
+	g_return_val_if_fail (node || key, 0);
+	g_return_val_if_fail (monitor != NULL, 0);
+
+	res = ++key_monitors_id;
+
+	cl = g_new (GOConfClosure, 1);
+	cl->monitor = monitor;
+	cl->node = node;
+	cl->data = data;
+	cl->key = g_strdup (key);
+	cl->real_key = go_conf_get_real_key (node, key);
+
+	if (!key_monitor_by_id)
+		key_monitor_by_id =
+			g_hash_table_new (g_direct_hash, g_direct_equal);
+	g_hash_table_insert (key_monitor_by_id,
+			     GUINT_TO_POINTER (res),
+			     cl);
+
+	if (!key_monitors_by_path)
+		key_monitors_by_path =
+			g_hash_table_new_full
+			(g_str_hash, g_str_equal, g_free, NULL);
+
+	cls = g_hash_table_lookup (key_monitors_by_path, cl->real_key);
+	cls = g_slist_prepend (cls, cl);
+	g_hash_table_replace (key_monitors_by_path,
+			      g_strdup (cl->real_key),
+			      cls);
+
+	return res;
 }
diff --git a/goffice/app/go-conf.c b/goffice/app/go-conf.c
index 42bbcdc..4596945 100644
--- a/goffice/app/go-conf.c
+++ b/goffice/app/go-conf.c
@@ -36,6 +36,22 @@
 #define d(code)
 #endif
 
+typedef struct {
+	GOConfMonitorFunc monitor;
+	GOConfNode *node;
+	gpointer data;
+	char *key;
+	char *real_key;
+} GOConfClosure;
+
+static void
+go_conf_closure_free (GOConfClosure *cls)
+{
+	g_free (cls->key);
+	g_free (cls->real_key);
+	g_free (cls);
+}
+
 #ifdef GOFFICE_WITH_GCONF
 #include "go-conf-gconf.c"
 #elif defined G_OS_WIN32