[gthumb: 9/20] removed FIXME comments



commit 5811f6e352e70510f63b2859608714ef6ed031f2
Author: Paolo Bacchilega <paobac src gnome org>
Date:   Sun Mar 28 17:45:51 2010 +0200

    removed FIXME comments

 gthumb/gth-browser.c                 |   39 ++++++++++++++-------------------
 gthumb/gth-cell-renderer-thumbnail.c |    2 +-
 gthumb/gth-file-list.c               |    8 +------
 3 files changed, 19 insertions(+), 30 deletions(-)
---
diff --git a/gthumb/gth-browser.c b/gthumb/gth-browser.c
index b9ecfb4..b0f5072 100644
--- a/gthumb/gth-browser.c
+++ b/gthumb/gth-browser.c
@@ -1161,7 +1161,7 @@ _gth_browser_set_sort_order (GthBrowser      *browser,
 	gth_file_list_set_sort_func (GTH_FILE_LIST (browser->priv->file_list),
 				     sort_type->cmp_func,
 				     inverse);
-	gth_file_list_set_sort_func (GTH_FILE_LIST (browser->priv->thumbnail_list),  /* FIXME */
+	gth_file_list_set_sort_func (GTH_FILE_LIST (browser->priv->thumbnail_list),
 				     sort_type->cmp_func,
 				     inverse);
 	gth_browser_update_title (browser);
@@ -1387,8 +1387,8 @@ load_data_continue (LoadData *load_data,
 		filter = _gth_browser_get_file_filter (browser);
 		gth_file_list_set_filter (GTH_FILE_LIST (browser->priv->file_list), filter);
 		gth_file_list_set_files (GTH_FILE_LIST (browser->priv->file_list), files);
-		gth_file_list_set_filter (GTH_FILE_LIST (browser->priv->thumbnail_list), filter); /* FIXME */
-		gth_file_list_set_files (GTH_FILE_LIST (browser->priv->thumbnail_list), files); /* FIXME */
+		gth_file_list_set_filter (GTH_FILE_LIST (browser->priv->thumbnail_list), filter);
+		gth_file_list_set_files (GTH_FILE_LIST (browser->priv->thumbnail_list), files);
 		g_object_unref (filter);
 		break;
 	default:
@@ -2363,7 +2363,7 @@ filterbar_changed_cb (GthFilterbar *filterbar,
 
 	filter = _gth_browser_get_file_filter (browser);
 	gth_file_list_set_filter (GTH_FILE_LIST (browser->priv->file_list), filter);
-	gth_file_list_set_filter (GTH_FILE_LIST (browser->priv->thumbnail_list), filter); /* FIXME */
+	gth_file_list_set_filter (GTH_FILE_LIST (browser->priv->thumbnail_list), filter);
 	g_object_unref (filter);
 
 	_gth_browser_update_statusbar_list_info (browser);
@@ -3175,6 +3175,8 @@ _gth_browser_make_file_visible (GthBrowser  *browser,
 	if (file_pos < 0)
 		return;
 
+	/* the main file list */
+
 	view = gth_browser_get_file_list_view (browser);
 	g_signal_handlers_block_by_func (view, gth_file_view_selection_changed_cb, browser);
 	gth_file_selection_unselect_all (GTH_FILE_SELECTION (view));
@@ -3204,7 +3206,7 @@ _gth_browser_make_file_visible (GthBrowser  *browser,
 		gth_file_view_scroll_to (GTH_FILE_VIEW (view), file_pos, align);
 	}
 
-	/* FIXME */
+	/* the thumbnail list in viewer mode */
 
 	view = gth_browser_get_thumbnail_list_view (browser);
 	g_signal_handlers_block_by_func (view, gth_thumbnail_view_selection_changed_cb, browser);
@@ -3460,17 +3462,17 @@ _gth_browser_construct (GthBrowser *browser)
 	browser->priv->viewer_sidebar = gth_sidebar_new ("file-tools");
 	gtk_paned_pack2 (GTK_PANED (browser->priv->viewer_sidebar_pane), browser->priv->viewer_sidebar, FALSE, TRUE);
 
-	{
-		/* FIXME */
-
-		browser->priv->thumbnail_list = gth_file_list_new (GTH_FILE_LIST_TYPE_THUMBNAIL);
-		gth_file_list_set_caption (GTH_FILE_LIST (browser->priv->thumbnail_list), "none");
-		gth_file_view_set_spacing (GTH_FILE_VIEW (gth_file_list_get_view (GTH_FILE_LIST (browser->priv->thumbnail_list))), 0);
-		gth_file_list_set_thumb_size (GTH_FILE_LIST (browser->priv->thumbnail_list), 95);
-		gtk_paned_pack2 (GTK_PANED (browser->priv->viewer_thumbnails_pane), browser->priv->thumbnail_list, FALSE, FALSE);
+	browser->priv->thumbnail_list = gth_file_list_new (GTH_FILE_LIST_TYPE_THUMBNAIL);
+	gth_file_list_set_caption (GTH_FILE_LIST (browser->priv->thumbnail_list), "none");
+	gth_file_view_set_spacing (GTH_FILE_VIEW (gth_file_list_get_view (GTH_FILE_LIST (browser->priv->thumbnail_list))), 0);
+	gth_file_list_set_thumb_size (GTH_FILE_LIST (browser->priv->thumbnail_list), 95);
+	gtk_paned_pack2 (GTK_PANED (browser->priv->viewer_thumbnails_pane), browser->priv->thumbnail_list, FALSE, FALSE);
+	_gth_browser_set_thumbnail_list_visibility (browser, eel_gconf_get_boolean (PREF_UI_THUMBNAIL_LIST_VISIBLE, TRUE));
 
-		_gth_browser_set_thumbnail_list_visibility (browser, eel_gconf_get_boolean (PREF_UI_THUMBNAIL_LIST_VISIBLE, TRUE));
-	}
+	g_signal_connect (G_OBJECT (gth_file_list_get_view (GTH_FILE_LIST (browser->priv->thumbnail_list))),
+			  "selection_changed",
+			  G_CALLBACK (gth_thumbnail_view_selection_changed_cb),
+			  browser);
 
 	/* -- browser page -- */
 
@@ -3647,13 +3649,6 @@ _gth_browser_construct (GthBrowser *browser)
 			  G_CALLBACK (gth_file_list_key_press_cb),
 			  browser);
 
-	/* FIXME */
-
-	g_signal_connect (G_OBJECT (gth_file_list_get_view (GTH_FILE_LIST (browser->priv->thumbnail_list))),
-			  "selection_changed",
-			  G_CALLBACK (gth_thumbnail_view_selection_changed_cb),
-			  browser);
-
 	browser->priv->file_list_popup = gtk_ui_manager_get_widget (browser->priv->ui, "/FileListPopup");
 
 	/* the filter bar */
diff --git a/gthumb/gth-cell-renderer-thumbnail.c b/gthumb/gth-cell-renderer-thumbnail.c
index d821dfe..a71451d 100644
--- a/gthumb/gth-cell-renderer-thumbnail.c
+++ b/gthumb/gth-cell-renderer-thumbnail.c
@@ -323,7 +323,7 @@ gth_cell_renderer_thumbnail_render (GtkCellRenderer      *cell,
   	else
   		state = ((flags & GTK_CELL_RENDERER_FOCUSED) == GTK_CELL_RENDERER_FOCUSED) ? GTK_STATE_ACTIVE : GTK_STATE_NORMAL;
 
-	if (self->priv->is_icon /*|| (state != GTK_STATE_NORMAL) FIXME */ || ((image_rect.width < self->priv->size) && (image_rect.height < self->priv->size))) {
+	if (self->priv->is_icon || ((image_rect.width < self->priv->size) && (image_rect.height < self->priv->size))) {
 		int R = 7;
 
 		if (state == GTK_STATE_NORMAL)
diff --git a/gthumb/gth-file-list.c b/gthumb/gth-file-list.c
index 295c0b3..1b2d3f8 100644
--- a/gthumb/gth-file-list.c
+++ b/gthumb/gth-file-list.c
@@ -622,7 +622,7 @@ gth_file_list_construct (GthFileList     *file_list,
 	g_object_set (renderer,
 		      "size", file_list->priv->thumb_size,
 		      "yalign", 1.0,
-		      "fixed_size", (file_list->priv->type == GTH_FILE_LIST_TYPE_THUMBNAIL), /* FIXME */
+		      "fixed_size", (file_list->priv->type == GTH_FILE_LIST_TYPE_THUMBNAIL),
 		      NULL);
 	gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (file_list->priv->view), renderer, FALSE);
 
@@ -867,11 +867,6 @@ gfl_add_files (GthFileList *file_list,
 				     g_object_ref (file_data->file),
 				     thumb_data_new ());
 
-		/* FIXME
-		if (gth_file_store_find (file_store, file_data->file, NULL))
-			continue;
-		*/
-
 		icon = g_file_info_get_icon (file_data->info);
 		pixbuf = gth_icon_cache_get_pixbuf (file_list->priv->icon_cache, icon);
 		metadata = _gth_file_list_get_metadata (file_list, file_data);
@@ -916,7 +911,6 @@ gfl_delete_files (GthFileList *file_list,
 		GFile       *file = scan->data;
 		GtkTreeIter  iter;
 
-		/* FIXME */
 		if (g_hash_table_lookup (file_list->priv->thumb_data, file) == NULL)
 			continue;
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]