[eog] Workaround concurrency issue with statusbar-date plugin



commit 46b027696fd73c115efe6d13421105750a0bf86c
Author: Felix Riemann <friemann gnome org>
Date:   Sat Nov 13 14:08:44 2010 +0100

    Workaround concurrency issue with statusbar-date plugin
    
    Make sure that only an image loading job does autorotation. A metadata
    loading job has no use for this. Works around lost signals when the
    statusbar-date plugin is activated. Works around bug 622161.

 src/eog-image.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/eog-image.c b/src/eog-image.c
index 71ebc68..8a95b38 100644
--- a/src/eog-image.c
+++ b/src/eog-image.c
@@ -1256,9 +1256,11 @@ eog_image_load (EogImage *img, EogImageData data2read, EogJob *job, GError **err
 
 #ifdef HAVE_EXIF
 	/* Check that the metadata was loaded at least once before
-	 * trying to autorotate. */
+	 * trying to autorotate. Also only an image load job should try to
+	 * autorotate an image. */
 	if (priv->autorotate && 
-	    priv->metadata_status == EOG_IMAGE_METADATA_READY) {
+	    priv->metadata_status == EOG_IMAGE_METADATA_READY &&
+	    data2read & EOG_IMAGE_DATA_IMAGE) {
 		eog_image_real_autorotate (img);
 	}
 #endif



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]