[gnumeric] Handle error condition



commit ca8291d4ab11827d73ca09157e9f5bbc38f4d14c
Author: Andreas J Guelzow <aguelzow pyrshep ca>
Date:   Mon Nov 22 13:45:00 2010 -0700

    Handle error condition
    
    2010-11-22  Andreas J. Guelzow <aguelzow pyrshep ca>
    
    	* dialog-sheet-order.c (cb_toggled_lock): bail on error
    	(cb_toggled_direction): ditto

 src/dialogs/ChangeLog            |    5 +++++
 src/dialogs/dialog-sheet-order.c |    4 ++++
 2 files changed, 9 insertions(+), 0 deletions(-)
---
diff --git a/src/dialogs/ChangeLog b/src/dialogs/ChangeLog
index 9d2a4e1..9b59522 100644
--- a/src/dialogs/ChangeLog
+++ b/src/dialogs/ChangeLog
@@ -1,3 +1,8 @@
+2010-11-22  Andreas J. Guelzow <aguelzow pyrshep ca>
+
+	* dialog-sheet-order.c (cb_toggled_lock): bail on error
+	(cb_toggled_direction): ditto
+
 2010-11-07  Sameer Morar <smorar gmail com>
 
 	* dialog-quit.c (foreach_is_file_set): new
diff --git a/src/dialogs/dialog-sheet-order.c b/src/dialogs/dialog-sheet-order.c
index 7ef463f..a51cb09 100644
--- a/src/dialogs/dialog-sheet-order.c
+++ b/src/dialogs/dialog-sheet-order.c
@@ -532,6 +532,8 @@ cb_toggled_lock (G_GNUC_UNUSED GtkCellRendererToggle *cell,
 		}
 	} else {
 		g_warning ("Did not get a valid iterator");
+		gtk_tree_path_free (path);
+		return;
 	}
 	gtk_tree_path_free (path);
 
@@ -570,6 +572,8 @@ cb_toggled_direction (G_GNUC_UNUSED GtkCellRendererToggle *cell,
 			 -1);
 	} else {
 		g_warning ("Did not get a valid iterator");
+		gtk_tree_path_free (path);
+		return;
 	}
 
 	gtk_tree_path_free (path);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]