[libgda] GdaBrowser: misc corrections

[Vivien Malerba <vivien src gnome org>]

commit 94589b72af8ea444682adf9052f4f81243366e73
Author: Vivien Malerba <malerba gnome-db org>
Date:   Tue Sep 7 21:22:55 2010 +0200

    GdaBrowser: misc corrections

 tools/browser/data-manager/data-console.c          |    3 +--
 tools/browser/data-manager/data-source-manager.c   |    3 +++
 tools/browser/data-manager/data-source.c           |    2 +-
 tools/browser/help/C/data-manager-perspective.page |    2 +-
 tools/browser/help/C/figures/data-man-persp.png    |  Bin 42049 -> 105450 bytes
 .../browser/help/C/figures/data-man-xmlcompose.png |  Bin 26347 -> 43932 bytes
 6 files changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/tools/browser/data-manager/data-console.c b/tools/browser/data-manager/data-console.c
index 4347fe2..b930b8c 100644
--- a/tools/browser/data-manager/data-console.c
+++ b/tools/browser/data-manager/data-console.c
@@ -388,7 +388,7 @@ data_console_new (BrowserConnection *bcnc)
 	g_signal_connect (button, "clicked",
 			  G_CALLBACK (editor_clear_clicked_cb), dconsole);
 
-	button = browser_make_small_button (FALSE, _("Add data source"), GTK_STOCK_ADD,
+	button = browser_make_small_button (FALSE, _("Add"), GTK_STOCK_ADD,
 					    _("Add a new data source"));
 	dconsole->priv->add_source_button = button;
 	gtk_box_pack_start (GTK_BOX (bbox), button, FALSE, FALSE, 0);
@@ -718,7 +718,6 @@ add_source_mitem_activated_cb (GtkMenuItem *mitem, DataConsole *dconsole)
 	GSList *list;
 
 	table = (gchar*) g_object_get_data ((GObject*) mitem, "_table");
-	g_print ("Add data source for [%s]\n", table);
 
 	source = data_source_new (dconsole->priv->bcnc, DATA_SOURCE_UNKNOWN);
 	list = (GSList*) data_source_manager_get_sources (dconsole->priv->mgr);
diff --git a/tools/browser/data-manager/data-source-manager.c b/tools/browser/data-manager/data-source-manager.c
index 375c67b..c5ba40e 100644
--- a/tools/browser/data-manager/data-source-manager.c
+++ b/tools/browser/data-manager/data-source-manager.c
@@ -255,6 +255,9 @@ source_depends_on (DataSource *source1, DataSource *source2)
 	GSList *holders;
 	GHashTable *export_columns;
 	export_columns = data_source_get_export_columns (source2);
+	if (!export_columns)
+		return FALSE;
+
 	for (holders = import->holders; holders; holders = holders->next) {
 		GdaHolder *holder = (GdaHolder*) holders->data;
 		if (GPOINTER_TO_INT (g_hash_table_lookup (export_columns, gda_holder_get_id (holder))) >= 1) {
diff --git a/tools/browser/data-manager/data-source.c b/tools/browser/data-manager/data-source.c
index d291bc9..4f33de6 100644
--- a/tools/browser/data-manager/data-source.c
+++ b/tools/browser/data-manager/data-source.c
@@ -900,7 +900,7 @@ data_source_set_params (DataSource *source, GdaSet *params)
 /**
  * data_source_get_export_names
  *
- * Returns: an array of strings, or %NULL
+ * Returns: an array of strings (don't modify) or %NULL
  */
 GArray *
 data_source_get_export_names (DataSource *source)
diff --git a/tools/browser/help/C/data-manager-perspective.page b/tools/browser/help/C/data-manager-perspective.page
index e1e86cd..a1610d8 100644
--- a/tools/browser/help/C/data-manager-perspective.page
+++ b/tools/browser/help/C/data-manager-perspective.page
@@ -66,7 +66,7 @@
   <list>
     <item><p><gui>Reset</gui>: resets the XML editor to a default XML template, only available when the XML
     view is currently displayed</p></item>
-    <item><p><gui>Add data source</gui>: displays a popup menu with an entry per table to quickly add
+    <item><p><gui>Add</gui>: displays a popup menu with an entry per table to quickly add
     the whole contents of a table as a data source, only available when the UI
     editor is currently displayed</p></item>
     <item><p><gui>Variables</gui>: shows/hide the <link xref="variables-syntax">variables</link> panel where you can give values to the variables
diff --git a/tools/browser/help/C/figures/data-man-persp.png b/tools/browser/help/C/figures/data-man-persp.png
index 4e0eccd..c2c6434 100644
Binary files a/tools/browser/help/C/figures/data-man-persp.png and b/tools/browser/help/C/figures/data-man-persp.png differ
diff --git a/tools/browser/help/C/figures/data-man-xmlcompose.png b/tools/browser/help/C/figures/data-man-xmlcompose.png
index 3ebdca2..ecb0e4c 100644
Binary files a/tools/browser/help/C/figures/data-man-xmlcompose.png and b/tools/browser/help/C/figures/data-man-xmlcompose.png differ