[pitivi] Little cleaning/refactoring

[Edward Hervey <edwardrv src gnome org>]

commit 11252193fd61fd1829b1d6f9e692ef51b31338a3
Author: Thibault Saunier <tsaunier gnome org>
Date:   Wed Jul 21 10:21:32 2010 -0400

    Little cleaning/refactoring

 pitivi/effects.py             |    7 +++++--
 pitivi/factories/operation.py |    2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)
---
diff --git a/pitivi/effects.py b/pitivi/effects.py
index 609ead8..fdbe30f 100644
--- a/pitivi/effects.py
+++ b/pitivi/effects.py
@@ -50,7 +50,10 @@ from xdg import IconTheme
 #  _ Complex Audio/Video Effects
 
 (VIDEO_EFFECT, AUDIO_EFFECT)  = range(2)
-USELESS_EFFECTS = ["colorconvert", "coglogoinsert", "festival",]
+
+#AspectratioCrop is Blacklisted because of this bug:
+#https://bugzilla.gnome.org/show_bug.cgi?id=624882
+BLACKLISTED_EFFECTS = ["colorconvert", "coglogoinsert", "festival", "aspectratiocrop"]
 
 
 
@@ -106,7 +109,7 @@ class EffectsHandler(object):
         factlist = gst.registry_get_default().get_feature_list(gst.ElementFactory)
         for element_factory in factlist:
             klass = element_factory.get_klass()
-            if "Effect" in klass and element_factory.get_name() not in USELESS_EFFECTS:
+            if "Effect" in klass and element_factory.get_name() not in BLACKLISTED_EFFECTS:
                 name = element_factory.get_name()
                 effect = EffectFactory(name, name,
                                        self._getEffectCategories(name),
diff --git a/pitivi/factories/operation.py b/pitivi/factories/operation.py
index 3a8961c..de4e82b 100644
--- a/pitivi/factories/operation.py
+++ b/pitivi/factories/operation.py
@@ -96,7 +96,7 @@ class EffectFactory (TransformFactory):
     def _releaseBin(self, bin):
         elements = bin.elements()
         for element in elements.next():
-            del element #bin.remove(element)
+            del element
 
 
     def addInputStream(self, stream):